[Bug 13104] New: Changing TimeFormat on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Bug ID: 13104 Summary: Changing TimeFormat on a production server will create duplicate fines! Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6427 Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32499&action=edit Bug 13104 - Changing TimeFormat on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changing TimeFormat on a |Changing date or time |production server will |format on a production |create duplicate fines! |server will create | |duplicate fines! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- When I filed the patch, I did not think about the fact that DateFormat has the same effect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32499|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32519&action=edit Bug 13104 - Changing date or time format on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The same situation applies to DateFormat. The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32519|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32521&action=edit Bug 13104 - Changing date or time format on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The same situation applies to DateFormat. The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32521|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32573&action=edit [PASSED QA] Bug 13104 - Changing date or time format on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The same situation applies to DateFormat. The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Adds some documentation to warn about the problem. Tested the new addition shows up in po files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12188 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15312 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org