[Bug 38658] New: SIP not marking patrons expired unless NotifyBorrowerDeparture has a positive value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Bug ID: 38658 Summary: SIP not marking patrons expired unless NotifyBorrowerDeparture has a positive value Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 25813 changed the way that SIP reports patron expiry. Prior to this bug patrons could eb marked as expired without setting this pref, now it requires a value. To recreate: 0 - Set NotifyBorrowerDeparture to 30 1 - Set a patron's expiry date to be in the past, I used Edna Acosta 2 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron 23529001000463 -m patron_information 3 - Note you are warned patron is expired 4 - Set NotifyBorrowerDeparture to 0 5 - repeat 2 6 - No notice that patron is expired, and patron status does not show any blocks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 [Bug 25813] Enhance patron expiration in SIP display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 175954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175954&action=edit Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Please note that the behavior with NotifyBorrowerDeparture now differs in SIP and at the OPAC, where no warning is displayed to an expired patron when NotifyBorrowerDeparture is disabled or unset. To be fair, now that you've pointed it, I find it strange that the warning about being expired is not displayed at the OPAC when NotifyBorrowerDeparture is disabled or unset, but that can be the subject of another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175954|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176099&action=edit Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176099|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 178103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178103&action=edit Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be a bug fix instead of an enhancement? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 --- Comment #7 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Hi Katrin, Yes, this is a bugfix. I've set it to "normal". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38658 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org