[Bug 9049] New: rebuild_zebra clears register even when shadow indexing fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Priority: P5 - low Change sponsored?: --- Bug ID: 9049 Assignee: gmcharlt@gmail.com Summary: rebuild_zebra clears register even when shadow indexing fails Severity: major Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Searching Product: Koha So far as I can tell, even if shadow indexing fails, rebuild_zebra.pl merrily clears the register, resulting in an empty database despite the precaution of using the shadow index. This seems like a rather large problem to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|rebuild_zebra clears |rebuild_zebra should not |register even when shadow |use shadow when called with |indexing fails |-r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- It turns out this is actually a limitation of Zebra. In light of this, we should not be using shadow when -r is specified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13372&action=edit Bug 9049: Don't use shadow with rebuild_zebra -r Due to a limitation of Zebra, the register must be cleared *before* doing shadow indexing if you want to reset the indexes. In light of that, it does not make sense to do shadow indexing at all when rebuild_zebra.pl is run with the -r switch. This patch makes -r (reset) imply -n (no shadow). To test: 1) Run `rebuild_zebra.pl -b -r -v -v -v` 2) Note that the script never runs the merge phase -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 13372 [details] Bug 9049: Don't use shadow with rebuild_zebra -r
Due to a limitation of Zebra, the register must be cleared *before* doing shadow indexing if you want to reset the indexes. In light of that, it does not make sense to do shadow indexing at all when rebuild_zebra.pl is run with the -r switch. This patch makes -r (reset) imply -n (no shadow).
To test: 1) Run `rebuild_zebra.pl -b -r -v -v -v` 2) Note that the script never runs the merge phase
how do i determine whether step 2/ does, or does not happen? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #3)
how do i determine whether step 2/ does, or does not happen?
When the merge is run there are messages like "Merge 0.6% complete (25 minutes remaining)... merge 1.2% complete (24 minutes remaining)... merge 1.8% complete (23 minutes remaining" etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13372|0 |1 is obsolete| | --- Comment #5 from wajasu <matted-34813@mypacks.net> --- Created attachment 13637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13637&action=edit 0001-SIGNED-OFF-Bug-9049-Don-t-use-shadow-with-rebuild_zebra I ran the rebuild grepping for part of the word "Merge" and the second time, no merge phase happened. koha@biblio:~/kohaclone/misc/migration_tools$ ./rebuild_zebra.pl -b -r -v -v -v 2>&1 | grep erge 08:47:56-22/11 zebraidx(6220) 20672912c27f0000 [log] Merge 99.9% completed; 0 seconds remaining koha@biblio:~/kohaclone/misc/migration_tools$ ./rebuild_zebra.pl -b -r -v -v -v 2>&1 | grep erge koha@biblio:~/kohaclone/misc/migration_tools$ I also did some searches afterward and things worked the same as I could see. wajasu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813@mypacks.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Trivial patch QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried reproducing the described behaviour, but following the test plan, I had no 'merge' line in the rebuild_zebra.pl output. Maybe I don't have enough test data. Could someone else please take a look at this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #6)
I tried reproducing the described behaviour, but following the test plan, I had no 'merge' line in the rebuild_zebra.pl output. Maybe I don't have enough test data. Could someone else please take a look at this?
Same behaviour here $ ./rebuild_zebra.pl -b -r -v -v -v 2>&1 | grep -i merge $ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13637|0 |1 is obsolete| | --- Comment #8 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 13939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13939&action=edit [Signed-Off] [Passed-QA] Bug 9049: Don't use shadow with rebuild_zebra -r Due to a limitation of Zebra, the register must be cleared *before* doing shadow indexing if you want to reset the indexes. In light of that, it does not make sense to do shadow indexing at all when rebuild_zebra.pl is run with the -r switch. This patch makes -r (reset) imply -n (no shadow). To test: 1) Run `rebuild_zebra.pl -b -r -v -v -v` 2) Note that the script never runs the merge phase Without the patch I see log lines refering to the shadow cache (enabling shadow spec=/home/koha/koha-dev/var/lib/zebradb/biblios/shadow:20G) With the patch I don't see anything in the logs about shadow. I do however see lines about merging. I think it could just be a misunderstanding of the logs Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Elliott Davis <elliott@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9049 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org