[Bug 7358] New: basket.pl : it is possible to affect a closed basket to a closed basketgroup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Bug #: 7358 Summary: basket.pl : it is possible to affect a closed basket to a closed basketgroup Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: henridamien.laurent@biblibre.com QAContact: ian.walls@bywatersolutions.com When affecting a closed basket to a basketgroup, the list shows all the basketgroup, even closed basketgroups. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #1 from laurenthdl <henridamien.laurent@biblibre.com> 2011-12-14 15:10:37 UTC --- Created attachment 6784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6784 proposed patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@biblib | |re.com --- Comment #2 from Francois Charbonnier <francois.charbonnier@biblibre.com> 2011-12-14 16:52:13 UTC --- It doesn't work. This is how I tested : 1/ i created 2 new baskets with one order line in each. 2/ for the first one, I created a basket group and closed it. I let the second one "free" 3/ I opened a new basket group. 4/ I can see it in the basket group list in the basket page. 5/ But, if I'm on the first basket pag,e I can't see the basket group, this basket is in. Even if it's close, for a specific basket, I should get this info. But, all I have in the list is : "Add new group" and "no group". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|--- |Failed QA AssignedTo|henridamien@koha-fr.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6784|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11739&action=edit Bug 7358: reaffect a closed basket to a closed basketgroup The list of basketgroups when looking at a closed basket show all the basketgroups. It should not be possible to affect a basket to a closed basketgroup, since this basketgroup should have been sent to a supplier. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |jonathan.druart@biblibre.co | |m Assignee|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11739|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13228&action=edit Bug 7358: reaffect a closed basket to a closed basketgroup The list of basketgroups when looking at a closed basket show all the basketgroups. It should not be possible to affect a basket to a closed basketgroup, since this basketgroup should have been sent to a supplier. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Tested, closed groups no longer selectable and are marked as closed! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA QA Contact| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * introduces new string "(closed)" * passes koha-qa.pl * fixes an annoying problem, even if an unfrequent one Overall: * passed QA * should wait for 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13228|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13316&action=edit Bug 7358: reaffect a closed basket to a closed basketgroup The list of basketgroups when looking at a closed basket show all the basketgroups. It should not be possible to affect a basket to a closed basketgroup, since this basketgroup should have been sent to a supplier. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |3.12 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I just tested this and was successfully able to add a closed basket to a closed basketgroup both before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #8)
I just tested this and was successfully able to add a closed basket to a closed basketgroup both before and after applying the patch.
Could you detail what you did, because I tested and had no problem -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #9)
(In reply to comment #8)
I just tested this and was successfully able to add a closed basket to a closed basketgroup both before and after applying the patch.
Could you detail what you did, because I tested and had no problem
1) Created a new basket. 2) Created a new basketgroup for that basket. 3) Closed the basket. 4) Closed the basketgroup. 5) Created a new basket. 6) Closed the new basket. 7) Viewed this new basket, and changed its basketgroup to the basketgroup I had previously created and closed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #10)
7) Viewed this new basket, and changed its basketgroup to the basketgroup I had previously created and closed.
I can't reproduce it neither. At the last step, when I am on the basket detail page (acqui/basket.pl?basketno=XX), the toolbar has 2 buttons ("Reopen this basket" and "Export this basket as CSV") and there is a "Basket group" dropdown list on the right, with 3 options : "no group", "add new group" and "my new basketgroup (closed)". The last one is disabled and cannot be selected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #11)
(In reply to comment #10)
7) Viewed this new basket, and changed its basketgroup to the basketgroup I had previously created and closed.
I can't reproduce it neither.
At the last step, when I am on the basket detail page (acqui/basket.pl?basketno=XX), the toolbar has 2 buttons ("Reopen this basket" and "Export this basket as CSV") and there is a "Basket group" dropdown list on the right, with 3 options : "no group", "add new group" and "my new basketgroup (closed)". The last one is disabled and cannot be selected
Did my earlier steps match the expected workflow? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #12)
Did my earlier steps match the expected workflow?
Yes! :-/ In fact only a closed basket can be linked to a basketgroup. You cannot change the basketgroup for a closed basket (unless there is no basketgroup already linked). You cannot add a basket to a basketgroup already closed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- It strikes me the problem might be bug 8892. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #14)
It strikes me the problem might be bug 8892.
Hum, not sure. It works for me using plack. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch works for me on current master: 1) Created first order, closed it, attached it to a basket group and closed it. 2) Created second order, closed it, not creating a basket group for it. 3) Tried to changed the basket group, but the closed basket group was greyed out and marked closed. I am not using Plack - not sure where the problem could be. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. This time I was able to reproduce the problem and confirm the solution. I'm not sure what I was doing wrong before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7358 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org