http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12243 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12243 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28203&action=edit Bug 12243 - Records with invalid ISBNs can cause searches to fail Some types of invalid ISBNs, when run throught C4::Koha::NormalizeISBN can produce ISBN objects that contain invalid ISBNs. This can be reproduced with an ISBN that has an invalid prefix, group code or publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)". When attempting to look up a record with such an ISBN, you will get an error along the lines of: Can't call method "as_string" on an undefined value Instead of checking for the BAD_ISBN state, we should be checking for the GOOD_ISBN state vi the method is_valid. Test Plan: 1) Edit a record, add the following ISBN to your record: 0788893777 (2 DVD 45th ed) 2) When Koha redirects to the record, you should see the error message described 3) Apply this patch 4) Reload the page, you should now see your record -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12243 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28203|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 28233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28233&action=edit Bug 12243 - Records with invalid ISBNs can cause searches to fail Some types of invalid ISBNs, when run throught C4::Koha::NormalizeISBN can produce ISBN objects that contain invalid ISBNs. This can be reproduced with an ISBN that has an invalid prefix, group code or publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)". When attempting to look up a record with such an ISBN, you will get an error along the lines of: Can't call method "as_string" on an undefined value Instead of checking for the BAD_ISBN state, we should be checking for the GOOD_ISBN state vi the method is_valid. Test Plan: 1) Edit a record, add the following ISBN to your record: 0788893777 (2 DVD 45th ed) 2) When Koha redirects to the record, you should see the error message described 3) Apply this patch 4) Reload the page, you should now see your record Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12243 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28233|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28244&action=edit Bug 12243 - Records with invalid ISBNs can cause searches to fail Some types of invalid ISBNs, when run throught C4::Koha::NormalizeISBN can produce ISBN objects that contain invalid ISBNs. This can be reproduced with an ISBN that has an invalid prefix, group code or publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)". When attempting to look up a record with such an ISBN, you will get an error along the lines of: Can't call method "as_string" on an undefined value Instead of checking for the BAD_ISBN state, we should be checking for the GOOD_ISBN state vi the method is_valid. Test Plan: 1) Edit a record, add the following ISBN to your record: 0788893777 (2 DVD 45th ed) 2) When Koha redirects to the record, you should see the error message described 3) Apply this patch 4) Reload the page, you should now see your record Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12243 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.