[Bug 7841] New: Several warnings on language from webinstaller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Priority: P5 - low Change sponsored?: --- Bug ID: 7841 CC: gmcharlt@gmail.com Assignee: henridamien@koha-fr.org Summary: Several warnings on language from webinstaller QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy@rijksmuseum.nl Hardware: All Status: NEW Version: master Component: Installation and upgrade (web-based installer) Product: Koha To be resolved warnings like: [Wed Mar 28 15:45:24 2012] [error] [client 82.173.53.17] [Wed Mar 28 15:45:24 2012] install.pl: Use of uninitialized value $string in pattern match (m//) at /usr/share/koha/testclone/C4/Languages.pm line 424. [Wed Mar 28 15:45:24 2012] [error] [client 82.173.53.17] [Wed Mar 28 15:45:24 2012] install.pl: Use of uninitialized value $current_language in string eq at /usr/share/koha/testclone/C4/Languages.pm line 301. [Wed Mar 28 15:45:24 2012] [error] [client 82.173.53.17] [Wed Mar 28 15:45:24 2012] install.pl: Use of uninitialized value in string eq at /usr/share/koha/testclone/C4/Languages.pm line 319. (Occurring several times in the log.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|henridamien@koha-fr.org |koha-bugs@lists.koha-commun | |ity.org QA Contact|koha.sekjal@gmail.com | --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marce, can you give some more information about this? How to reproduce? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Goto staff client. Instead of logging in, goto webinstaller via /cgi-bin/koha/installer/install.pl?step=3&op=updatestructure This directly produces a bunch of warnings (10 for this one attempt?) in the staff log like: install.pl: Use of uninitialized value $string in pattern match (m//) at /usr/share/koha/testclone/C4/Languages.pm line 439 OR Use of uninitialized value $current_language in string eq at /usr/share/koha/testclone/C4/Languages.pm line 316 OR Use of uninitialized value in string eq at /usr/share/koha/testclone/C4/Languages.pm line 334 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- I have added tests into t/db_dependent/Languages.t which should trigger these same messages. I have then corrected C4/Languages.pm accordingly. If anyone thinks this is lacking, let me know. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I have changed this from enhancement (which has been a default :( ) to minor, as floody logs are a royal pain! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 28267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28267&action=edit Bug 7841 - Tests to detect no changes When called with undef, floody messages appear in the error logs. Less floody messages appear when using 'en' as the language. TEST PLAN --------- 1) apply the patch 2) prove -v t/db_dependent/Languages.t -- All the tests should pass, including the last two which a) check that when undef is used no language is marked as current. b) check that when 'en' is used there is a language marked as current. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 28268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28268&action=edit Bug 7841 - Tweaks to remove floody messages from tests. This modifies lines in C4/Languages.pm such that when the tests are run, they no longer generate errors. TEST PLAN --------- 1) Apply first patch 2) prove -v t/db_dependent/Languages.t -- There will be uninitialized string messages, etc. 3) Apply second patch (this one) 4) prove -v t/db_dependent/Languages.t -- Only one carp message will remain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- See comment 5 and comment 6 for the corresponding test plans. This should make C4/Languages.pm less floody. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28267|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28272&action=edit [SIGNED-OFF] Bug 7841 - Tests to detect no changes When called with undef, floody messages appear in the error logs. Less floody messages appear when using 'en' as the language. TEST PLAN --------- 1) apply the patch 2) prove -v t/db_dependent/Languages.t -- All the tests should pass, including the last two which a) check that when undef is used no language is marked as current. b) check that when 'en' is used there is a language marked as current. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28268|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28273&action=edit [SIGNED-OFF] Bug 7841: Tweaks to remove floody messages from tests. This modifies lines in C4/Languages.pm such that when the tests are run, they no longer generate errors. TEST PLAN --------- 1) Apply first patch 2) prove -v t/db_dependent/Languages.t -- There will be uninitialized string messages, etc. 3) Apply second patch (this one) 4) prove -v t/db_dependent/Languages.t -- Only one carp message will remain. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no warnings, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28272|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28292&action=edit [PASSED QA] Bug 7841 - Tests to detect no changes When called with undef, floody messages appear in the error logs. Less floody messages appear when using 'en' as the language. TEST PLAN --------- 1) apply the patch 2) prove -v t/db_dependent/Languages.t -- All the tests should pass, including the last two which a) check that when undef is used no language is marked as current. b) check that when 'en' is used there is a language marked as current. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28273|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28293&action=edit [PASSED QA] Bug 7841: Tweaks to remove floody messages from tests. This modifies lines in C4/Languages.pm such that when the tests are run, they no longer generate errors. TEST PLAN --------- 1) Apply first patch 2) prove -v t/db_dependent/Languages.t -- There will be uninitialized string messages, etc. 3) Apply second patch (this one) 4) prove -v t/db_dependent/Languages.t -- Only one carp message will remain. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no warnings, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7841 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a direct regression test that uses Test::Warn to check for the presence of warnings. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org