[Bug 37739] New: Can't delete vendors after Bootstrap 5 update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Bug ID: 37739 Summary: Can't delete vendors after Bootstrap 5 update Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com After the Bootstrap 5 update (bug 35402) you can no longer delete vendors. To test that deleting a vendor doesn't work after the Bootstrap 5 update: 1. Start up KTD with the latest main. 2. Go to Acquisitions > Manage orders section - select the 'Search' button. 3. Add two or three new vendors: . + New vendor . Name: Vendor 1, 2, 3 and so on 4. List all the vendors: Acquisitions > Manage orders section - select the 'Search' button. 5. Select 'Delete vendor' for any of the newly created vendors. 6. Note that nothing happens. 7. Note that there are no console errors if you use the browser web developer tools. To test that deleting a vendor works before the Bootstrap 5 update: 1. Check out the Koha git repository before the Bootstrap update: git checkout f44d2cccc7 2. Shut down KTD. 3. Start up KTD again. 4. Go to Acquisitions > Manage orders section - select the 'Search' button. 5. Add three or four new vendors: . + New vendor . Name: Vendor 1, 2, 3 and so on 6. List all the vendors: Acquisitions > Manage orders section - select the 'Search' button. 7. Select 'Delete vendor' for any of the newly created vendors. 8. In a pop-up window, you are prompted "Are you sure you want to delete this vendor?". 9. Select 'Yes'. 10. Go to Acquisitions > Manage orders section - select the 'Search' button. 11. The vendor you deleted is no longer listed. (Note: After starting up KTD again on main, I had to do a yarn install, yarn build, and restart_all.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170751&action=edit Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170751|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170792&action=edit Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes acquisitions so release notes| |that you can now delete | |vendors. (This is related | |to the OPAC and staff | |interface Bootstrap 5 | |upgrade in Koha 24.11 (bug | |35402) and bug 31921, which | |added a confirmation pop-up | |window when deleting a | |vendor.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170792|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170822&action=edit Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170823&action=edit Bug 37739: (follow-up) Add extra space in markup Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37739 Bug 37739 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org