[Bug 13474] New: Untranslatable log actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Bug ID: 13474 Summary: Untranslatable log actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Log actions "RENEW", "CHANGE PASS", "ADDCIRCMESSAGE" and "DELCIRCMESSAGE" are untranslatable, need to be added to translate_log_action block in viewlog.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46933&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Please confirm this is the fix that you are looking for! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- I think this is a good start. However: mtompset@debian:~/kohaclone$ git grep "[ ]logaction(" | cut -f2 -d":" | cut -f2 -d"," | cut -f2 -d"(" | sed -e "s#^ *##g" | sed -e "s#\"#'#g" | sort -u 'ADD' 'ADDCIRCMESSAGE' 'CHANGE PASS' 'CREATE' 'DELCIRCMESSAGE' 'DELETE' 'ISSUE' 'MODIFY' 'RENEW' 'RETURN' 'Run' mtompset@debian:~/kohaclone$ [% BLOCK translate_log_action %] [% SWITCH action %] [% CASE 'ADD' %]Add [% CASE 'DELETE' %]Delete [% CASE 'MODIFY' %]Modify [% CASE 'ISSUE' %]Checkout [% CASE 'RETURN' %]Return [% CASE 'CREATE' %]Create [% CASE %][% action %] [% END %] [% END %] SCRATCH PAD: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' There is one more action missing: 'Run'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46933|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47051&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Aleisha Amohia from comment #3)
Created attachment 47051 [details] [review] Bug 13474: Adding untranslatable log actions to viewlog.tt
Added 'Run'
Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Sorry, your case is wrong. The code is literally 'Run', not 'RUN'. Yes, I found that strange too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47051|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47073&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47073|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 47272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47272&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> (Amended to remove tab chars to make qa tools happy) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15658 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 [Bug 15658] Browse system logs: Add more actions to action filter list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org