http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46341|0 |1 is obsolete| | --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 46385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46385&action=edit Bug 15501 - Planned Irregularities are deleted when modifying subscription Test plan : Before applying patch 1) Go to serials Home page 2) Choose an existing subscription (from a daily, weekly or monthly serial) and edit 3) Go to second page and launch the prediction pattern test 4) Check some checkboxes 5) Save. 6) Edit again and add a note on first page 7) Go to next page and Save : you can see there had been no alert. 8) Edit again, go to next page and launch prediction pattern test : You see that the checkboxes you had selected are not any more checked. Now apply the patch and redo all steps 2 to 6. 7) when you click on Save button, an alert warn you that you must launch the prediciton test before. Do it and save. 8) When you edit again and launch again the prediction test, you can see that the checkboxes selected are still checked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46385|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 46411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46411&action=edit Bug 15501 - Planned Irregularities are deleted when modifying subscription Add a warning to avoid saving a subscription whitout testing prediction pattern when there are planned no published issues Signed-off-by: Liz Rea <liz@catalyst.net.nz> Ran through test plan, looks all good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46411|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46422&action=edit Bug 15501 - Planned Irregularities are deleted when modifying subscription Add a warning to avoid saving a subscription whitout testing prediction pattern when there are planned no published issues Signed-off-by: Liz Rea <liz@catalyst.net.nz> Ran through test plan, looks all good. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Isn't this line problematic? [% IF ( irregularity ) %]patternneedtobetested=1[% END %] Shouldn't it be (with ;): [% IF ( irregularity ) %]patternneedtobetested=1;[% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 --- Comment #10 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Arghhh! you are right, I will post a follow-up Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.