[Bug 27026] New: New circulation rule "Days mode" values are not explained anywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Bug ID: 27026 Summary: New circulation rule "Days mode" values are not explained anywhere Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It appears that the new Days mode value in the circulation conditions is not explained and the values are rather cryptic - especially if you are supposed to translate them: Calendar DateDue Days DayWeek Default There are references in the code, but I don't see where they show up visibly. And the DaysMode system preference doesn't use the codes so you can't make the connection there easily. Might be missing something, but glad to be told! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- DateDue means "next opening day"...? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Days is supposed to mean 'ignore the calendar' but if you look at translations that won't work well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #2)
Days is supposed to mean 'ignore the calendar' but if you look at translations that won't work well.
Especially since this string is used in lots of places :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113739&action=edit Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days mode" There was a tooltip for values of the existing rules, but not the only you were editing. Now there is the same tooltip (title) on the option elements of the dropdown list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Would this patch works for you? We can even have it post string freeze as the strings already existed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, thx for taking a look at this! The titles will certainly help, but I feel like we should really change the options offered. I know they are derived from the database values for the syspref, but I feel they make not much sense, especially when people try to translate them (and they will, especially since calendar appears in multiple places like the tools start page). <option value="" title="Use the system preference 'useDaysMode' as a default value">Default</option> <option value="Calendar" title="Use the calendar to skip days the library is closed">Calendar</option> <option value="Datedue" title="Use the calendar to push the due date to the next open day">Datedue</option> <option value="Days" title="Ignore the calendar">Days</option> <option value="Dayweek" title="Use the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise">Dayweek</option> Why not use something more speaking? Default Skip closed days Next open day Same week day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113770&action=edit Bug 27026: Use meaningful descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113807&action=edit Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days mode" There was a tooltip for values of the existing rules, but not the only you were editing. Now there is the same tooltip (title) on the option elements of the dropdown list. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113808&action=edit Bug 27026: Use meaningful descriptions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113807|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113912&action=edit Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days mode" There was a tooltip for values of the existing rules, but not the only you were editing. Now there is the same tooltip (title) on the option elements of the dropdown list. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113808|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113913&action=edit Bug 27026: Use meaningful descriptions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- As a step towards QA, here is another signoff. And the QA script passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- These look reasonable to me and are an improvement.. I must admit I still get confused by 'Next open day' vs 'Skip closed days'.. they seem equivalent in description to me... what do they do differently? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Says you have: Today is Wed Nov 4th, Sat and Sun are closed, as well as Nov 11th November 2020 Su Mo Tu We Th Fr Sa 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 * "Calendar - Use the calendar to skip days the library is closed": With today + 7 days you will get 16th (skipping 7, 8, 11, 14, 15) * "Use the calendar to push the due date to the next open day": With today + 7 days you will get 12th: today + 7 gave you 11th, which is a closed day, so you get the day after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan beat me to it :) Next opening day counts all calendar days and just shifts to next opening day at the end, if it hits a closed day. Skip closed days doesn't count them at all for the loan period (thus always landing on an opening day I think). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113912|0 |1 is obsolete| | Attachment #113913|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113987&action=edit Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days mode" There was a tooltip for values of the existing rules, but not the only you were editing. Now there is the same tooltip (title) on the option elements of the dropdown list. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113987|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113988&action=edit Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days mode" There was a tooltip for values of the existing rules, but not the only you were editing. Now there is the same tooltip (title) on the option elements of the dropdown list. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Bug 27026: Use meaningful descriptions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches squashed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependencies, not backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 [Bug 27280] Explanation for "Days mode" is not consistent -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org