[Bug 17320] New: MySQL 5.7 doesn't work well with SQL using '0000-00-00'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Bug ID: 17320 Summary: MySQL 5.7 doesn't work well with SQL using '0000-00-00' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Several SQL statements in updatedatabase.pl have '0000-00-00'. A simple substitution to 0 will prevent a default MySQL 5.7 on Ubuntu from barfing. This patch will touch as far back as 3.0.6, but given the magnitude of other errors while upgrading, finding no 0000-00-00 barfs after the patch up to 3.9 and then finding no 0000-00-00 barfs from 3.14.x upwards seems sufficient to check. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 55706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55706&action=edit Bug 17320: Make '0000-00-00' into 0 See comment 0. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17324 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17260 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17234 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does it work as expected with older MySQL versions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #2)
Does it work as expected with older MySQL versions?
I ran it on Debian 8, and it worked too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17324 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17260 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17234 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16887, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7806, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15087, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4392 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #4 from Barton Chittenden <barton@bywatersolutions.com> --- Test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Barton Chittenden from comment #4)
Test plan?
Run an upgrade, make sure there are no '0000-00-00' related red errors in the web install. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Barton Chittenden from comment #4)
Test plan?
P.P.S. Comment #0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17234 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- While preparing to test for bug 17234, I went back to 3.14.x, installed an empty install with all the sample data. I had to patch it with 2 changes in the kohastructure and the ignore error from C4/Installer.pm to get it to install with just 3 visible errors. I then changed to master, and run updatedatabase.pl from the command line. Here is the output (shortened): mtompset@ubuntu:~/kohaclone$ ./installer/data/mysql/updatedatabase.pl [SNIP] Upgrade to 3.21.00.008 done (Bug 7981: Transfer message on return. HomeOrHoldingBranchReturn syspref removed in favour of circulation rules.) DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'datecancellationprinted' at row 1 [for Statement " UPDATE aqorders SET orderstatus='cancelled' WHERE (datecancellationprinted IS NOT NULL OR datecancellationprinted<>'0000-00-00'); "] at ./installer/data/mysql/updatedatabase.pl line 10607. Upgrade to 3.21.00.009 done (Bug 13993: Correct orderstatus for transferred orders) [SNIP] Koha clean installs 3.22.x and higher currently, but the upgrade process is still flaky from anything before that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 56819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56819&action=edit Bug 17320 [DO NOT PUSH] Make 3.14.x "install" Tweak fields, so primary key is workable. Ignore command line mysql error security warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- TEST PLAN --------- On an Ubuntu 16.04 LTS git install: git checkout -b bug_17320 origin/3.20.x git bz apply 17320 i -- apply the DO NOT PUSH -- in a MySQL client drop and recreate your koha_library DB -- run a web install and select all data (just 3 issues for Marc21, but not really the point of this patch) git reset --hard origin/master ./installer/data/mysql/updatedatabase.pl -- there will be 0000-00-00 messages in the upgrade output. git reset --hard origin/3.20.x git bz apply 17320 i -- apply the DO NOT PUSH -- in a MySQL client drop and recreate your koha_library DB -- run a web install and select all data (just 3 issues for Marc21, but not really the point of this patch) git reset --hard origin/master git bz apply 17320 i apply the 0000-00-00 fix patch ./installer/data/mysql/updatedatabase.pl -- there will be NO 0000-00-00 messages in the upgrade output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The test plan is wrong, we need to test the patch with older versions of MySQL as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dominic.pichette@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #11 from Dominic Pichette <dominic.pichette@inlibro.com> --- It appeared to need to be signed-off. but after reading the last comment of Jonathan Druart, I think it is better to change the status to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- After bug 7806 we will assume that we reached a stable state. Please reopen bug reports if still happened when pushed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org