[Bug 41993] New: Add a datatable to list available bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Bug ID: 41993 Summary: Add a datatable to list available bookings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Hello @ll Like the datatable containing pending bookings, it may be useful to add a table displaying the list of bookable items. This would take into account specific rules (lead and trail periods) and be joined with current checkouts to certify their availability. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #1 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 194490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194490&action=edit Bug 41993: Add datatable for items available for bookings Test plan: 1) Apply this patch, rebuild sources and restart_all 2) On Circulation module you will see a new links into "Holds and bookings" section, click on "Items available for bookings" 3) First of all the datatable list your bookable items but not filtered 4) On the left you have many filters for the datatable, please note that dates are modified on server side to include lead and trail periods if they exist. Sponsored by: Loire Forez Agglomération -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a datatable to list |Add a page to show items |available bookings |available for bookings Circulation| |Bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194490|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194543&action=edit Bug 41993: Add a page to show items available for bookings Test plan: 1) Apply this patch, rebuild sources and restart_all 2) On Circulation module you will see a new links into "Holds and bookings" section, click on "Items available for bookings" 3) First of all the datatable list your bookable items but not filtered 4) On the left you have many filters for the datatable, please note that dates are modified on server side to include lead and trail periods if they exist. Sponsored by: Loire Forez Agglomération Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194544&action=edit Bug 41993: (follow-up) Tidy and other QA fixes Fixing issues raised by the QA tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194545&action=edit Bug 41993: (follow-up) Fix markup of sidebar menu, correct Select2 style The library selection in the sidebar works better if we use Select2. I made a corresponding minor change to select2.css. This patch also restructures the in-page JavaScript so that template variables are in a separate <script> block (see Bug 41563 etc.). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Failed QA --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This patch introduces a new interface (Items available for bookings) but includes accessibility issues: - Form controls (inputs/selects) without associated labels - Fieldset used without a <legend> - Inconsistent labeling across filter controls - Potential empty or unclear table headers in the DataTable Because this is new UI, accessibility requirements should be met before sign-off. Please ensure: - All form controls have associated <label> elements (or aria-label/aria-labelledby) - Fieldsets include meaningful <legend> elements - Table headers contain descriptive text Happy to re-test once updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199303&action=edit Bug 41993: (follow-up) Fix some QA issues - Replace <h4> with <legend> in the sidebar (and tweak the SCSS a little). - Add nonce attributes to <script> tags. - Change "Homebranch" to "Home library." - Change "Callnumber" to "Call number." - Define missing JS variable based on template variable "start_date_default." The WAVE plugin identifies several issues which are related to our use of DataTables and Select2. Those are out of scope for this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194543|0 |1 is obsolete| | Attachment #194544|0 |1 is obsolete| | Attachment #194545|0 |1 is obsolete| | Attachment #199303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #7 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206957&action=edit Bug 41993: Add a page to show items available for bookings Test plan: 1) Apply this patch, rebuild sources and restart_all 2) On Circulation module you will see a new links into "Holds and bookings" section, click on "Items available for bookings" 3) First of all the datatable list your bookable items but not filtered 4) On the left you have many filters for the datatable, please note that dates are modified on server side to include lead and trail periods if they exist. Sponsored by: Loire Forez Agglomération Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #8 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206958&action=edit Bug 41993: (follow-up) Tidy and other QA fixes Fixing issues raised by the QA tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #9 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206959&action=edit Bug 41993: (follow-up) Fix markup of sidebar menu, correct Select2 style The library selection in the sidebar works better if we use Select2. I made a corresponding minor change to select2.css. This patch also restructures the in-page JavaScript so that template variables are in a separate <script> block (see Bug 41563 etc.). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #10 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206960&action=edit Bug 41993: (follow-up) Fix some QA issues - Replace <h4> with <legend> in the sidebar (and tweak the SCSS a little). - Add nonce attributes to <script> tags. - Change "Homebranch" to "Home library." - Change "Callnumber" to "Call number." - Define missing JS variable based on template variable "start_date_default." The WAVE plugin identifies several issues which are related to our use of DataTables and Select2. Those are out of scope for this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41993 --- Comment #11 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206961&action=edit Bug 41993: (follow-up) tidy -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org