[Bug 18573] New: Error when adding anonymous suggestion in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Bug ID: 18573 Summary: Error when adding anonymous suggestion in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I have enabled AnonSuggestions and defined a valid borrowernumber in AnonymousPatron. When I go to /cgi-bin/koha/opac-suggestions.pl?op=add I get an error: Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- git bisect points to Bug 17847 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17847 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63356&action=edit Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error when adding anonymous |Error when adding a |suggestion in the OPAC |suggestion in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63356|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 63369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63369&action=edit Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Reproduced without patch, OK with patch Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- QAing this now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63369|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 63379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63379&action=edit Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Reproduced without patch, OK with patch Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency is not part of 16.11.x, so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org