[Bug 33913] New: Improve translation of title tags: Catalog, holds, and ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Bug ID: 33913 Summary: Improve translation of title tags: Catalog, holds, and ILL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify catalog, holds, and ILL templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve translation of |Improve translation of |title tags: Catalog, holds, |title tags: Circulation, |and ILL |holds, and ILL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152116&action=edit Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds https://bugs.koha-community.org/show_bug.cgi?id=33907 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152116|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152117&action=edit Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152117|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152305&action=edit Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152305|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 154670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154670&action=edit Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Overall this is a nice improvement, but there are a few where we lose context: Now: %s Batch check out to %s › %s Circulation › Koha␠ %1$s: IF patron %2$s: INCLUDE 'patron-title.inc' invert_name = 1 no_html = 1 %3$s: END The second %s can be moved if needed, the hints make it clear that it's a patron's name. New: Batch check out to There will no longer be a clue, that this string is followed by a name and you will no longer be able to move the placeholder as it might be required for correct grammar. There are a few more of these: + [% t("Checking out to") | html %] [% INCLUDE 'patron-title.inc' invert_name = 1 no_html = 1 %] › + [% t("Batch check out to") | html %] [% INCLUDE 'patron-title.inc' invert_name = 1 no_html = 1 %] › + [% t("Items overdue as of") | html %] [% todaysdate | $KohaDates %] › -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: [% t("Place a hold on") | html %] [% INCLUDE 'biblio-title-head.inc' %] › -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154670|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154752&action=edit Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154753&action=edit Bug 33913: (QA follow-up) Move variables into strings To test: 1) Checking out to {patron} * Search for any patron * Click on cardnumber in patron search results * Verify that page title reads correctly and includes patron's name 2) Batch check out to {patron} * Activate BatchCheckouts system preference * Check all patron categories for BatchCheckoutsValidCategories * Go to any patron account * Click on batch checkout tab * Verify that the page title reads correctly and includes patron's name 3) Place a hold on {title} * Search for a record with items in the staff interface catalog * Click on 'place holds' * Verify that the page title reads correctly and includes the title of the record 4) Overdues as of {date} * Set DateFormat system preference to any other than default * Go to circulation > overdues * Verify the page title includes today's date in the correct format Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen or Caroline - could you maybe double-check my last patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154753|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154800&action=edit Bug 33913: (QA follow-up) Move variables into strings To test: 1) Checking out to {patron} * Search for any patron * Click on cardnumber in patron search results * Verify that page title reads correctly and includes patron's name 2) Batch check out to {patron} * Activate BatchCheckouts system preference * Check all patron categories for BatchCheckoutsValidCategories * Go to any patron account * Click on batch checkout tab * Verify that the page title reads correctly and includes patron's name 3) Place a hold on {title} * Search for a record with items in the staff interface catalog * Click on 'place holds' * Verify that the page title reads correctly and includes the title of the record 4) Overdues as of {date} * Set DateFormat system preference to any other than default * Go to circulation > overdues * Verify the page title includes today's date in the correct format Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- I choose to not backport to stable to avoid too much translation work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33913 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org