[Bug 14200] New: GetNormalizedISBN failing to normalize valid ISBNs in some cases
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Bug ID: 14200 Summary: GetNormalizedISBN failing to normalize valid ISBNs in some cases Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39178&action=edit Bug 14200 - Unit Tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39179&action=edit Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39178|0 |1 is obsolete| | Attachment #39179|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39197&action=edit [SIGNED-OFF] Bug 14200 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39198&action=edit [SIGNED-OFF] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39197|0 |1 is obsolete| | Attachment #39198|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39296&action=edit Bug 14200 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39297&action=edit Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch Version|3.18 |master CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good work Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org