[Bug 10755] New: Add "Keyword as Phrase" to staff client advanced search indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Bug ID: 10755 Summary: Add "Keyword as Phrase" to staff client advanced search indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, there are "...as Phrase" indexes for title, author, subject, corporate name, personal name, and conference name in the staff client. At the request of several librarians, this patch adds one for "Keyword". While we have had some discussion/debate about the best way to go forward with the available indexes in the OPAC, there's really no reason not to include this one in the staff client, especially since your more advanced searchers are (possibly) going to be librarians using the staff interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 20452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20452&action=edit Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes This patch adds a "Keyword as Phrase" index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the "Keyword" drop-down list. 2) Note that there is only a "Keyword" not a "Keyword as Phrase" option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a "Keyword as Phrase" option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find "Keyword Adjacent To Keyword" rather than a more scattershot search that finds the keywords regardless of their position to each other. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20452|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20552&action=edit [SIGNED-OFF] Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes This patch adds a "Keyword as Phrase" index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the "Keyword" drop-down list. 2) Note that there is only a "Keyword" not a "Keyword as Phrase" option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a "Keyword as Phrase" option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find "Keyword Adjacent To Keyword" rather than a more scattershot search that finds the keywords regardless of their position to each other. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Template change is correct, and in my tests the searching behavior was correctly modified: Using "keyword as phrase" returned only results where the terms were adjacent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20552|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20737&action=edit Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes This patch adds a "Keyword as Phrase" index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the "Keyword" drop-down list. 2) Note that there is only a "Keyword" not a "Keyword as Phrase" option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a "Keyword as Phrase" option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find "Keyword Adjacent To Keyword" rather than a more scattershot search that finds the keywords regardless of their position to each other. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Template change is correct, and in my tests the searching behavior was correctly modified: Using "keyword as phrase" returned only results where the terms were adjacent. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, trivial patch with no possible side effects. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org