http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-21 03:39:09 UTC --- Created attachment 3377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3377 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-22 13:12:08 UTC --- Created attachment 3396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3396 'Edit' link After applying the patch, I still see the "Edit" link (see attached screenshot). I think we can completely hide the authorities toolbar to users who don't have permissions, since they can't use any of the buttons it provides. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3377|0 |1 is obsolete| | Attachment #3396|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-05 16:13:12 UTC --- Created attachment 5311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5311 proposed patch (updated) The proposed patch was for H::T. As the file affected was .inc, that also exist for T::T, it was still applying, but no more working. This patch has been updated for T::T (+ few reindenting fixed + javascript variable put into the IF) I tested successfully this patch, please sign-off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 13:44:27 UTC --- After applying this patch I still see edit authority on this page: cgi-bin/koha/authorities/auth_finder.pl?op=do_search&type=intranet&index=tag_100_subfield_a_22862_738128&authtypecode=PERSO_NAME&marclist=mainmainentry&and_or=and&operator=contains&value_mainstr=k&marclist=mainentry&and_or=and&operator=contains&and_or=and&operator=contains&orderby=HeadingAsc I'm not sure where this patch was supposed to remove that link from because it's not clear from the patch description. Please let me know all the places to look when the updated patch is submitted. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-09-07 13:10:50 UTC --- Yup, The librarian I tested with had cataloging permissions and some circulation permissions but not editauthorities. I'll test again and get you a screenshot of the permissions my staff user has. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-09-07 13:14:18 UTC --- Created attachment 5338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5338 able to edit authorities The link to edit authorities is still showing even though she doesn't have the right permissions. I tried in Firefox and Chrome. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |christophe.croullebois@bibl | |ibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.