[Bug 10622] New: Add --sip and --nosip switches to koha-list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Bug ID: 10622 Summary: Add --sip and --nosip switches to koha-list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz It might be useful for batch calls, and also for use in koha-common.init. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19852&action=edit Bug 10622: add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- To test: - pick the koha-list script from this patch, and - test ./koha-list --help, ./koha-list -h for usage options - All switches should work as expected (--noemail --email --sip --nosip). That's it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10624 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- It might not be a while before I can test this, but I do approve of the idea and at a read the code looks good. So if someone else looks at it first, that's great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19852|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 20213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20213&action=edit Bug 10622: [SIGNED OFF] add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> I applied the patch on my local dev install, and then copied the patched koha-list script to a couple of servers with actual instances running off the packages, to test the script. - It seems that the -h switch did not work before this patch, now both -h and --help works nicely - --sip and --nosip work as expected, also in combination with --email and --noemail The patch does not add --sip and --nosip to the man page for koha-list, but I will do a followup for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 20214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20214&action=edit Bug 10622 - Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20214|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 20221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20221&action=edit Bug 10622 - [SIGNED OFF] Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Forgot the docs this time, good catch Magnus -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10003 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20213|0 |1 is obsolete| | --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 21219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21219&action=edit Bug 10622: [SIGNED OFF] add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> I applied the patch on my local dev install, and then copied the patched koha-list script to a couple of servers with actual instances running off the packages, to test the script. - It seems that the -h switch did not work before this patch, now both -h and --help works nicely - --sip and --nosip work as expected, also in combination with --email and --noemail The patch does not add --sip and --nosip to the man page for koha-list, but I will do a followup for that. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20221|0 |1 is obsolete| | --- Comment #8 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 21220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21220&action=edit Bug 10622 - [SIGNED OFF] Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Forgot the docs this time, good catch Magnus Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás and Magnus! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org