[Bug 9360] New: Clean borrowers tool wording and layout problematic
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Bug ID: 9360 Summary: Clean borrowers tool wording and layout problematic Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: jcamins@cpbibliography.com The wording in the clean borrowers tool is not idiomatic, and the layout with the three options under "Delete borrowers" is confusing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 --- Comment #1 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14456&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. Other ergonomic change suggestions welcomed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 --- Comment #2 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Suppose I should note that this work is based on bug 9076, which was just pushed today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This has a few minor errors which prevent it from validating as well-formed XHTML: - A missing quotation mark on line 68: id=borrower_dateexpiry" - Two instances of "<br>" which should be "<br />" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 --- Comment #4 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- righto - will fix those (though the 2nd one is not my doing :)) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- The first, I mean. Gah. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14456|0 |1 is obsolete| | --- Comment #6 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14473&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. Other ergonomic change suggestions welcomed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Now we've got "<br \>" instead of "<br />" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14473|0 |1 is obsolete| | --- Comment #8 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14476&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Another nit: "checkout" occurs far more frequently than "check-out" in existing templates. "check-out", which this patch uses throughout, is currently used only in the following two templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/patron-attr-types.tt I don't much care which form is used, but we should be consistent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14476|0 |1 is obsolete| | --- Comment #10 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14507&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14533&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14507|0 |1 is obsolete| | Attachment #14533|0 |1 is obsolete| | --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14534&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. [Patch also amended by Galen Charlton to update the description on the tools page to use the word "patrons".] Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch introduces many tabulation characters. Please resubmit it replacing tab with 4 spaces. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14534|0 |1 is obsolete| | --- Comment #14 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14551&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 --- Comment #15 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- last patch fixes all instances of tab characters, and incorporates Galen's change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14551|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 14554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14554&action=edit [SIGNED-OFF] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. Signed-off-by: Marc Veron <veron@veron.ch> Behaves as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: No regression found. This patch works as expected, the title is changed on each page. It adds bullet points on the Batch patron deletion/anonymization page. Other changes are indentation. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14554|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14558&action=edit bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. Signed-off-by: Marc Veron <veron@veron.ch> Behaves as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Fix indentation and tabulations characters -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9360 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org