http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 André Melancia <Andy@Andy.COM.PT> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Andy@Andy.COM.PT -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14486&action=edit Proposed patch You are right André, the permission is not correct in upload_cover_image.pl. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14486|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14501&action=edit Bug 9065 - set correct permission for upload local cover image This patch fixes a problem where if a staff user has the upload_local_cover_images permission (and is not a superlibrarian and does not have all of the tools permissions), trying to use the "Tools -> Upload local cover image" will fail with "You do not have permissions [...]". To test after applying the patch: - Create a staff uesr that has just the catalogue and upload_local_cover_images permission. - Log in as that staff user. - Go to "Tools -> Upload local cover image". - Verify that one is given the form to upload a cover image. - Without the patch, one will be presented with the login form instead. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Thanks a lot Galen -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14501|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14520&action=edit Bug 9065 - set correct permission for upload local cover image This patch fixes a problem where if a staff user has the upload_local_cover_images permission (and is not a superlibrarian and does not have all of the tools permissions), trying to use the "Tools -> Upload local cover image" will fail with "You do not have permissions [...]". To test after applying the patch: - Create a staff uesr that has just the catalogue and upload_local_cover_images permission. - Log in as that staff user. - Go to "Tools -> Upload local cover image". - Verify that one is given the form to upload a cover image. - Without the patch, one will be presented with the login form instead. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> mysql> select * from permissions where code="upload_cover_images"; Empty set (0.00 sec) mysql> select * from permissions where code="upload_local_cover_images"; +------------+---------------------------+---------------------------+ | module_bit | code | description | +------------+---------------------------+---------------------------+ | 13 | upload_local_cover_images | Upload local cover images | +------------+---------------------------+---------------------------+ 1 row in set (0.00 sec) "git grep upload_cover_images" returns 0 result. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9065 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x, will be in 3.8.9 and 3.10.2 -- You are receiving this mail because: You are watching all bug changes.