[Bug 10793] New: XSLT change 780/785 search queries to use ti, phr indexes like other linking entries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Bug ID: 10793 Summary: XSLT change 780/785 search queries to use ti,phr indexes like other linking entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, the 780 (preceding entry)/785 (continuing entry) fields in the XSLT are using a plain "q=" search, while other linking entries like 773 (host item) and 775 (other edition) use the ti,phr indexes like so "q=ti,phr:". This bug seeks to change it so that the 780 and 785 fields use the ti,phr indexes for searching as well, since the search queries are populated using the "title" or "main entry heading" subfields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 20680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20680&action=edit Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Just changing this away from an enhancement to "minor" as it's really more of a bug fix than an enhancement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20680|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20843&action=edit Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20843|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20860&action=edit [PASSED QA] Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT change only, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note: To my knowledge phrase searches don't work over multiple subfields without additional work/DOM. This patch will create a search string like: ti,phr:<$a><$t>. This seems to produce relevant results, but might not always be as precise as intended. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, David! A version of this might be applicable to the NORMARC stylesheets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.6. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org