[Bug 10742] New: simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Bug ID: 10742 Summary: simple search to z39.50 search keeps index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 20409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20409&action=edit Bug 10742 - simple search to z39.50 search keeps index See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20409|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 20529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20529&action=edit Bug 10742 - simple search to z39.50 search keeps index In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. This patch simply adds kw as default value when the cgi does not have idx parameter. Test plan : - In intranet, perform a search from header that does not return any result. For example "afalseword" - Click on "Z39.50 Search" => you get a popup with the searched word in title. For example : Title: afalseword - Go to advanced search page - Enter the same word into first input and submit - Click on "Z39.50 Search" => you get a popup with the searched word in title. Signed-off-by: David Cook <dcook@prosentient.com.au> Patch works as described. This is much nicer than before. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- The only thing I wonder about is whether the contents of the simple search should go into "Title" or "Raw (any)", since "Raw" is more of a "keyword" search. I looked a bit at how to make it go into "Raw (any)" instead of "Title" but couldn't get it to work so I guess it would require more poking around. Perhaps "Title" makes the most sense, as people might be more likely to search for titles using the simple search than anything else? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to David Cook from comment #3)
Perhaps "Title" makes the most sense, as people might be more likely to search for titles using the simple search than anything else? It makes sense for me.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Another reason to keep the title might be that you can probably expect the Z39.50 target to support title search, but probably not all support raw? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #5)
Another reason to keep the title might be that you can probably expect the Z39.50 target to support title search, but probably not all support raw?
Mmm, I suppose that's a possibility, although I think the Bib-1 attribute for raw (1016) is fairly ubiquitous. I'm not too fussed either way. I just thought it might be worth raising :). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20529|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20609&action=edit [PASSED QA] Bug 10742 - simple search to z39.50 search keeps index In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. This patch simply adds kw as default value when the cgi does not have idx parameter. Test plan : - In intranet, perform a search from header that does not return any result. For example "afalseword" - Click on "Z39.50 Search" => you get a popup with the searched word in title. For example : Title: afalseword - Go to advanced search page - Enter the same word into first input and submit - Click on "Z39.50 Search" => you get a popup with the searched word in title. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change, fixes an annoying problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5645 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.6. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org