[Bug 42229] New: Form label used on non-form elements on opac-memberentry.tt pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Bug ID: 42229 Summary: Form label used on non-form elements on opac-memberentry.tt pages Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org On opac-memberentry.tt there are some form label's used on elements that are not part of a form. To recreate: 1. Log in into OPAC and go to the "Personal details" page. 2. See elements like: <li> <label>Username:</label> koha </li> You cannot interact with this, so it should not be <label> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 196689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196689&action=edit Bug 42229: Avoid using form labels for static values in opac-memberentry.tt The OPAC personal details page uses <label> elements in some places where no visible form control is present. In these cases, the content is display-only and the label is not associated with an interactive field. Replace those labels with non-form markup for static values while preserving existing labels for actual form controls. Test plan: 1. Log in to the OPAC and go to the "Personal details" page 2. Inspect display-only values such as Username and Expiration date 3. Confirm <label> elements are used for content that is not part of a form control 4. Apply the patch 5. Log in to the OPAC and go to the "Personal details" page 6. Confirm display-only values such as Username and Expiration date no longer use <label> elements 7. Confirm other static display-only values updated by the patch also no longer use <label> elements 8. Confirm actual form controls, such as text inputs and selects, still have proper associated labels 9. Run an accessibility checker and confirm the related label misuse issues are resolved 10. Sign off and have a great day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 196695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196695&action=edit Bug 42229: Avoid using form labels for static values in opac-memberentry.tt The OPAC personal details page uses <label> elements in some places where no visible form control is present. In these cases, the content is display-only and the label is not associated with an interactive field. Replace those labels with non-form markup for static values while preserving existing labels for actual form controls. Test plan: 1. Log in to the OPAC and go to the "Personal details" page 2. Inspect display-only values such as Username and Expiration date 3. Confirm <label> elements are used for content that is not part of a form control 4. Apply the patch 5. Log in to the OPAC and go to the "Personal details" page 6. Confirm display-only values such as Username and Expiration date no longer use <label> elements 7. Confirm other static display-only values updated by the patch also no longer use <label> elements 8. Confirm actual form controls, such as text inputs and selects, still have proper associated labels 9. Run an accessibility checker and confirm the related label misuse issues are resolved 10. Sign off and have a great day! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 196696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196696&action=edit Bug 42229: (follow-up) Markup correction The "Street type" fields had double "name" attributes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196695|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199420&action=edit Bug 42229: Avoid using form labels for static values in opac-memberentry.tt The OPAC personal details page uses <label> elements in some places where no visible form control is present. In these cases, the content is display-only and the label is not associated with an interactive field. Replace those labels with non-form markup for static values while preserving existing labels for actual form controls. Test plan: 1. Log in to the OPAC and go to the "Personal details" page 2. Inspect display-only values such as Username and Expiration date 3. Confirm <label> elements are used for content that is not part of a form control 4. Apply the patch 5. Log in to the OPAC and go to the "Personal details" page 6. Confirm display-only values such as Username and Expiration date no longer use <label> elements 7. Confirm other static display-only values updated by the patch also no longer use <label> elements 8. Confirm actual form controls, such as text inputs and selects, still have proper associated labels 9. Run an accessibility checker and confirm the related label misuse issues are resolved 10. Sign off and have a great day! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199421&action=edit Bug 42229: (follow-up) Markup correction The "Street type" fields had double "name" attributes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- There is a regression here: "Library card number" label is gone for SelfReg: 1) Enable PatronSelfRegistration 2) Don't login to the OPAC, visit self reg form: http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3) Confirm "Library card number" input is without a corresponding label -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200019&action=edit Bug 42229: (follow-up) Restore card number <label> when necessary Patch from commit 2b5c999 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42229 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.07 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org