[Bug 42232] New: Fieldset with missing legend on opac-messaging.tt page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Bug ID: 42232 Summary: Fieldset with missing legend on opac-messaging.tt page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To recreate: 1. Log on to the OPAC and go to "Messaging" page. 2. The fieldset that contains the Save/Cancel button is missing a legend. I think this can be added with a sr-only class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 197016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197016&action=edit Bug 42232: Add missing legend to action fieldset in OPAC To test: 1. Log on to the OPAC and go to "Messaging" page. 2. The fieldset that contains the Save/Cancel button is missing a legend. 3. Apply the patch and refresh the "Messaging" page. 4. Notice that the fieldset now contains an accessible legend. 5. Sign off and have a great day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 197110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197110&action=edit Bug 42232: Add missing legend to action fieldset in OPAC To test: 1. Log on to the OPAC and go to "Messaging" page. 2. The fieldset that contains the Save/Cancel button is missing a legend. 3. Apply the patch and refresh the "Messaging" page. 4. Notice that the fieldset now contains an accessible legend. 5. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an accessibility release notes| |issue on the patron's OPAC | |account messaging | |preferences form: Missing | |legend for the fieldset | |with submit changes and | |cancel buttons. | | | |It adds a legend tag | |"visible" for screen reader | |patrons so that it is clear | |for the group of buttons | |what they are being asked | |to do. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch, inspecting the HTML source: <fieldset class="action"> <input type="submit" value="Submit changes" class="btn btn-primary"> <a class="cancel" href="/cgi-bin/koha/opac-user.pl">Cancel</a> </fieldset> 2. After the patch: <fieldset class="action"> <legend class="sr-only">Submit or cancel changes</legend> <input type="submit" value="Submit changes" class="btn btn-primary"> <a class="cancel" href="/cgi-bin/koha/opac-user.pl">Cancel</a> </fieldset> 3. Surprising the axe DevTools didn't flag this as an issue, just going to show that while automated tools are useful, they don't always flag issues. Some references: - Vision Australia, Removing form barriers: When to use the fieldset and legend elements, https://www.visionaustralia.org/business-consulting/digital-access/removing-... - W3C, WCAG Techniques - Providing a description for groups of form controls using fieldset and legend elements, https://www.w3.org/WAI/WCAG22/Techniques/html/H71 - W3C, Forms Tutorial - Grouping Controls https://www.w3.org/WAI/tutorials/forms/grouping/ - Gov.UK: . Design system: Fieldset https://design-system.service.gov.uk/components/fieldset/ . Blog from 2016: Using the fieldset and legend elements https://accessibility.blog.gov.uk/2016/07/22/using-the-fieldset-and-legend-e... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fieldset with missing |Fieldset with missing |legend on opac-messaging.tt |legend on OPAC account |page |messaging settings page | |(opac-messaging.tt) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200196&action=edit Bug 42232: Add missing legend to action fieldset in OPAC To test: 1. Log on to the OPAC and go to "Messaging" page. 2. The fieldset that contains the Save/Cancel button is missing a legend. 3. Apply the patch and refresh the "Messaging" page. 4. Notice that the fieldset now contains an accessible legend. 5. Sign off and have a great day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42232 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.07 released in| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.07 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org