[Bug 41408] New: POS Inline Editing Triggers Form Submission on Enter Key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Bug ID: 41408 Summary: POS Inline Editing Triggers Form Submission on Enter Key Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk On the Point of Sale (POS) page, when editing the cost of an item using inline table editing (clicking to edit the price), pressing Enter to accept the new price inadvertently submits the entire payment form instead of just accepting the inline edit. Steps to Reproduce 1. Navigate to the Point of Sale page (pos/pay.pl) 2. Add an item to "This sale" table using the '+Add' button from the left table 3. Click on the "Cost" cell to edit the price inline 4. Change the value 5. Press Enter to accept the new price Expected Behavior - The Enter key should accept the inline edit and update the cell value - The form should NOT be submitted - User should be able to continue editing other fields or adding more items Actual Behavior - The Enter key accepts the inline edit BUT also triggers the form submission - The payment form is submitted prematurely - User cannot continue with the transaction setup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190352&action=edit Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Prevent inline editing in POS for the cost and quantity fields from submitting the form on 'Enter'. Test plan: 1. Ensure the POS page is accessible (Set UsePointOfSale, add a Cash Register and some Debit types for sale) 2. Navigate to the Point of Sale page (pos/pay.pl) 3. Add an item to the "This sale" table 4. Click on the "Cost" cell to edit the price inline 5. Change the value and press Enter 6. Expected: The cell value should update without submitting the form 7. Try editing the "Quantity" field as well (same fix applies) 8. Complete a normal transaction to ensure form submission still works with the submit button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190352|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190486&action=edit Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Prevent inline editing in POS for the cost and quantity fields from submitting the form on 'Enter'. Test plan: 1. Ensure the POS page is accessible (Set UsePointOfSale, add a Cash Register and some Debit types for sale) 2. Navigate to the Point of Sale page (pos/pay.pl) 3. Add an item to the "This sale" table 4. Click on the "Cost" cell to edit the price inline 5. Change the value and press Enter 6. Expected: The cell value should update without submitting the form 7. Try editing the "Quantity" field as well (same fix applies) 8. Complete a normal transaction to ensure form submission still works with the submit button Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |me@paulderscheid.xyz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190486|0 |1 is obsolete| | --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 190666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190666&action=edit Bug 41408: Added e.preventDefault() and e.stopPropagation() to edit Prevent inline editing in POS for the cost and quantity fields from submitting the form on 'Enter'. Test plan: 1. Ensure the POS page is accessible (Set UsePointOfSale, add a Cash Register and some Debit types for sale) 2. Navigate to the Point of Sale page (pos/pay.pl) 3. Add an item to the "This sale" table 4. Click on the "Cost" cell to edit the price inline 5. Change the value and press Enter 6. Expected: The cell value should update without submitting the form 7. Try editing the "Quantity" field as well (same fix applies) 8. Complete a normal transaction to ensure form submission still works with the submit button Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Inline editing the cost or release notes| |quantity fields on a point | |of sale transaction then | |pressing enter incorrectly | |submitted the form, instead | |of just updating the field. | | | |Now, the values in the | |fields are updated without | |submitting the form, and | |you can continue entering | |sale details and completing | |the transaction. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Inline editing the cost or |Inline editing the cost or release notes|quantity fields on a point |quantity fields on a point |of sale transaction then |of sale transaction, then |pressing enter incorrectly |pressing enter, incorrectly |submitted the form, instead |submitted the form--instead |of just updating the field. |of just updating the field. | | |Now, the values in the |Now, the values in the |fields are updated without |fields are updated without |submitting the form, and |submitting the form, and |you can continue entering |you can continue entering |sale details and completing |sale details and completing |the transaction. |the transaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Lets not impact behavior on older stable branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org