https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Sorry, no idea how to do step 2 - that is, have a framework apply to a standard ILL request, for example for a book. Could you please clarify how to get this to work/how this works? For the standard ILL request, selecting the Book type is the only one that creates a new record using the Fast Add Framework. I don't see a way to link a specific framework (such as the BKS framework) or set a default framework for a standard ILL request, as implied by the title of the bug and step 2 of the test plan. Thanks! David Testing notes (using KTD): 1. Enable the ILLModule system preference. 2. For the Fast Add Framework, I added "Author name" to the default value field for 100$a. 3. Create a standard ILL request: 3.1 ILL requests > New ILL request 3.2 Type = Book 3.3 Title = A test book 3.4 Card number, username or surname = 42 3.5 Destination library = Centerville 4. Look at the list of ILL requests. 5. In the request details column there is a link to a new record created using the Fast Add Framework. 6. On the record details page, By should have the default value entered in step 2. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to David Nind from comment #3)

Patch still applies, but no response to question in comment #2

In addition, the qa script complains about pod coverage:

Result: [FAIL] Koha/BiblioFramework.pm FAIL pod_coverage sub _type has no pod coverage.

That sub wasn't edited in the patch. The QA tool warns if there's any, but the guideline is that if you add (or edit) a sub you have to include/update pod coverage as needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192430|0 |1 is obsolete| | --- Comment #6 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 203867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203867&action=edit Bug 41757: Copy framework defaults to ILL Standard backend Now the pod coverage is fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #8 from Esther Melander <esther.melander@bywatersolutions.com> --- I followed the test plan it appeared to work as outline. The 100$a had the default value. I don't believe it is currently possible to easily assign a different framework for ILL Requests. These bugs address this question. Bug 39695 Bug 32773 (not specific to ILL requests, but opens the doorway for additional fast-add frameworks) However, the core functionality seems to work, so I see no reason to mark this as signed-off. -- You are receiving this mail because: You are watching all bug changes.