[Bug 23493] New: jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Bug ID: 23493 Summary: jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org We currently sparsely use this plugin on the checkouts table. It would be nice to switch to the equivalent plugin by the datatables authors and bundle it into our package. Doing so would allow other developers to take advantage of the feature as that version is well documented and supported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92443&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a somewhat rough and ready attempt at replacement to get someone started. I've directly included the new plugin via a CDN link, this would clearly need to be bundled in our datatables bundle, but I didn't want to add all there here in the first instance and confuse reviewers. I'm sure there's still more code that could be removed from the js file but it would be good to get some initial feedback or perhaps for someone to take it on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Is this patch complete? I'm not seeing the CDN import line among other things :) (In reply to Martin Renvoize from comment #2)
This is a somewhat rough and ready attempt at replacement to get someone started.
I've directly included the new plugin via a CDN link, this would clearly need to be bundled in our datatables bundle, but I didn't want to add all there here in the first instance and confuse reviewers.
I'm sure there's still more code that could be removed from the js file but it would be good to get some initial feedback or perhaps for someone to take it on.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92443|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92444&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oops, forgot to squash before uploading to BZ... should be better now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92444|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97324&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some feedback. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97324|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97344&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some feedback. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks great to me! I also find the styling to be a bit improved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this should be signed off - changing status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97344|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97694&action=edit Bug 23493: Replace rowGrouping with rowGroup This patch replaces the unmaintained third party rowGrouping datatables plugin with the supported core rowGroup replacement. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple rebase performed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am expecting this bug report to add the rowGroup plugin, not bug 23355. It seems easy to make the dependency the other way around. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97694|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97704&action=edit Bug 23493: Replace rowGrouping with rowGroup This patch replaces the unmaintained third party rowGrouping datatables plugin with the supported core rowGroup replacement. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23355 | Blocks| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dependency re-ordered as requested and suitable re-base undertaken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 609 "fnInitComplete": function(oSettings, json) { 610 // Disable rowGroup plugin after first use 611 // so any sorting on the table doesn't use it 612 //var oSettings = issuesTable.fnSettings(); Should we remove those 3 commented lines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- One change I noticed: when the column are sorted the "grouped tr" are displayed with this new version: https://snipboard.io/HzXJ4l.jpg (before) https://snipboard.io/zRb4sk.jpg (after) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, Removing the commented lines seems sensible.. I'll do that now.. As for the display discrepancy you mention.. I can't seem to replicate that. https://snipboard.io/1DOacC.jpg (before) https://snipboard.io/gOLAkD.jpg (after) There are subtle styling differences (which I'm sure can be resolved at the CSS level if we want to do so?), but I can't replicate the 'before' you show without grouping or the after with two "Today's" groupings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I bet you did not sort the column by "due date". Take a look at the "checked out on" and "due date" column on my screenshots. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97704|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98041&action=edit Bug 23493: Replace rowGrouping with rowGroup This patch replaces the unmaintained third party rowGrouping datatables plugin with the supported core rowGroup replacement. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98042&action=edit Bug 23493: (follow-up) Switch to aDataSort for multi-column sorting This patch adds aDataSort configurations for each sortable column such that we always maintain the group sorting primarily and apply a secondary sort using the column in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I see what you mean now.. good catch. See followup which I believe addresses the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not think it's correct, now we cannot really sort by due date: https://snipboard.io/TRx43j.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98041|0 |1 is obsolete| | Attachment #98042|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98055&action=edit Bug 23493: Replace rowGrouping with rowGroup This patch replaces the unmaintained third party rowGrouping datatables plugin with the supported core rowGroup replacement. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98056&action=edit Bug 23493: Remove commented lines Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok so I confused Martin with my previous comments. I wanted to highlight the fact that there was a behavior's change, but did not consider it a regression or blocker. I am happy with how it works as it. I have attached a follow-up to remove the 3 commented lines. Marked as Passed QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #26)
Nice work everyone!
Pushed to master for 20.05
There is something very wrong here Martin. You pushed: Bug 23493: (follow-up) Disable rowGroup on due date sort Bug 23493: (follow-up) Switch to aDataSort for multi-column sorting Bug 23493: Replace rowGrouping with rowGroup They all have my signed off. However I disagreed with the last 2. Additionally the last one has never been published here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 [Bug 24533] Improved sorting in checkouts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Corrected by reverting the errantly pushed patches and applying the followup here instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98118&action=edit Bug 23493: Fix selenium/regressions.t One test wants to make sure thead, tfood and tbody will have th/td's with the same size/number. Existing test for tbody was retrieving the grouped td, which has a colspan of 100%. Note that this 100% value seems to be wrong as it is interpreted like "100" by the browser. We do not want to test this row anyway, but the real row, the one with all the td's. This patch makes it retrieve the second tr and count the number of td it has. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98132&action=edit Bug 23493: (RM follow-up) Let datatables calculate colspan for us Prior to this we arbitrarily set a colspan of 100 for the rowgroup header row. If we remove the td wrapper from the render function then datatables will automatically wrap the output in an appropraite td with cell with fullwidth colspan correctly set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Bug 23493 depends on bug 23013, which changed state. Bug 23013 Summary: Upgrade DataTables in the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This last patch has been pushed to master for 20.05 on Jan 30. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18211 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org