[Bug 41335] New: Toggling the hold options does not always work in opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Bug ID: 41335 Summary: Toggling the hold options does not always work in opac-reserve Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Some combinations of OPACMandatoryHoldDates together with forced item level holds make the options collapsed while they should be expanded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Relation with DisplayMultiItemHolds ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
Relation with DisplayMultiItemHolds ?
Just another small issue: if there is only one item, we should probably preselect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190118&action=edit Bug 41335: Adjust toggling hold options, preselect lone item By default hold options are collapsed. In the following cases they are expanded: - one of the hold dates is made mandatory via OPACMandatoryHoldDates - an item level hold is forced for this biblio (at least one item is controlled by a circ rule where opacitemholds == F [Forced] ) When DisplayMultiItemHolds is enabled, item selection for specific items is done via checkboxes; no item is preselected unless there is only one. Otherwise an item is selected via radio buttons. The first one is preselected. Test plan: Verify in steps 2 to 4 that the above rules are respected. [1] Enable DisplayMultiItemHolds and OPACAllowHoldDateInFuture. [2] Place hold on biblio with only one item where record and item level are allowed. [3] Place hold on biblio with multiple items where item level is forced. [4] Place hold on biblio with multiple items where item level is not forced. [5] Toggle OPACMandatoryHoldDates (between no hold dates and another value) and repeat 2-4 [6] Disable DisplayMultiItemHolds and repeat 2-5 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190118|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190120&action=edit Bug 41335: Adjust toggling hold options, preselect lone item By default hold options are collapsed. In the following cases they are expanded: - one of the hold dates is made mandatory via OPACMandatoryHoldDates - an item level hold is forced for this biblio (at least one item is controlled by a circ rule where opacitemholds == F [Forced] ) When DisplayMultiItemHolds is enabled, item selection for specific items is done via checkboxes; no item is preselected unless there is only one. Otherwise an item is selected via radio buttons. The first one is preselected. Test plan: Verify in steps 2 to 4 that the above rules are respected. [1] Enable DisplayMultiItemHolds and OPACAllowHoldDateInFuture. [2] Place hold on biblio with only one item where record and item level are allowed. [3] Place hold on biblio with multiple items where item level is forced. [4] Place hold on biblio with multiple items where item level is not forced. [5] Toggle OPACMandatoryHoldDates (between no hold dates and another value) and repeat 2-4 [6] Disable DisplayMultiItemHolds and repeat 2-5 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Second version counts holdable items only for preselection of checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190120|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190286&action=edit Bug 41335: Adjust toggling hold options, preselect lone item By default hold options are collapsed. In the following cases they are expanded: - one of the hold dates is made mandatory via OPACMandatoryHoldDates - an item level hold is forced for this biblio (at least one item is controlled by a circ rule where opacitemholds == F [Forced] ) When DisplayMultiItemHolds is enabled, item selection for specific items is done via checkboxes; no item is preselected unless there is only one. Otherwise an item is selected via radio buttons. The first one is preselected. Test plan: Verify in steps 2 to 4 that the above rules are respected. [1] Enable DisplayMultiItemHolds and OPACAllowHoldDateInFuture. [2] Place hold on biblio with only one item where record and item level are allowed. [3] Place hold on biblio with multiple items where item level is forced. [4] Place hold on biblio with multiple items where item level is not forced. [5] Toggle OPACMandatoryHoldDates (between no hold dates and another value) and repeat 2-4 [6] Disable DisplayMultiItemHolds and repeat 2-5 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Jeroen De Meester <j.de.meester@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.de.meester@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Welcome Jeroen on this report :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190286|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 195324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195324&action=edit Bug 41335: Adjust toggling hold options, preselect lone item By default hold options are collapsed. In the following cases they are expanded: - one of the hold dates is made mandatory via OPACMandatoryHoldDates - an item level hold is forced for this biblio (at least one item is controlled by a circ rule where opacitemholds == F [Forced] ) When DisplayMultiItemHolds is enabled, item selection for specific items is done via checkboxes; no item is preselected unless there is only one. Otherwise an item is selected via radio buttons. The first one is preselected. Test plan: Verify in steps 2 to 4 that the above rules are respected. [1] Enable DisplayMultiItemHolds and OPACAllowHoldDateInFuture. [2] Place hold on biblio with only one item where record and item level are allowed. [3] Place hold on biblio with multiple items where item level is forced. [4] Place hold on biblio with multiple items where item level is not forced. [5] Toggle OPACMandatoryHoldDates (between no hold dates and another value) and repeat 2-4 [6] Disable DisplayMultiItemHolds and repeat 2-5 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Paul Derscheid from comment #8)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Great, thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When DisplayMultiItemHolds release notes| |is enabled, item selection | |for specific items is | |done via checkboxes; no | |item is preselected unless | |there is only one. | |Otherwise an item is | |selected via radio buttons. | |The first one is | |preselected. CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41335 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org