[Bug 41665] New: Only include Greybox in OPAC if IdRef is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Bug ID: 41665 Summary: Only include Greybox in OPAC if IdRef is enabled Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Greybox is only used in the OPAC for the IdRef feature in the UNIMARC XSLT. So we should only include it in that context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34710 [Bug 34710] Remove GreyBox from OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32333 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 191659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191659&action=edit Bug 41665: Only include Greybox in OPAC if IdRef is enabled This patch wraps the Greybox include in the OPAC with a syspref check on IdRef, so that it's only loaded when it's needed. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 2. Search through the HTML or the Sources tab in F12 tools and note that Greybox assets are not loaded 3. Enable the IdRef system preference 4. Note that the Greybox assets are loaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38366 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191659|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191708&action=edit Bug 41665: Only include Greybox in OPAC if IdRef is enabled This patch wraps the Greybox include in the OPAC with a syspref check on IdRef, so that it's only loaded when it's needed. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 2. Search through the HTML or the Sources tab in F12 tools and note that Greybox assets are not loaded 3. Enable the IdRef system preference 4. Note that the Greybox assets are loaded Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Legend. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This seems to be a very old library? I am wondering how we use it? I dont really see it being used in the idref context. Only came across this line: koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl: <xsl:attribute name="rel">gb_page_center[600,500]</xsl:attribute> Which looks odd too btw. And if it is that old, should we even use it? There is a reference to an official site: http://orangoo.com/labs/GreyBox This site does not respond Adding -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
Adding Fridolin for feedback
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status for now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is used indeed for opening a popup with IdRef datas. Bug 34710 will manage rewriting this. I attach a screenshot from AMU OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 195253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195253&action=edit Screenshot of IdRef popup Screenshot of IdRef popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #7)
This is used indeed for opening a popup with IdRef datas.
Bug 34710 will manage rewriting this.
I attach a screenshot from AMU OPAC.
Could you confirm that Greybox is not used here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- On the contrary, it is used here.
From XSLT file :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl: <xsl:attribute name="rel">gb_page_center[600,500]</xsl:attribute> gb_page_center is JS from Greybox I've found a page speaking about it (looks very old) : https://www.jqueryscript.net/demo/Simple-Pop-up-Window-Plugin-GreyBox/normal... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- We find gb_page_center in : https://git.koha-community.org/Koha-community/Koha/src/commit/a1c7b7062c025d... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thx for confirming that it is still used. Note also comment4 btw; it was not obvious from there only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191708|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 195261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195261&action=edit Bug 41665: Only include Greybox in OPAC if IdRef is enabled This patch wraps the Greybox include in the OPAC with a syspref check on IdRef, so that it's only loaded when it's needed. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 2. Search through the HTML or the Sources tab in F12 tools and note that Greybox assets are not loaded 3. Enable the IdRef system preference 4. Note that the Greybox assets are loaded Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8290 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34710 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Lets move on with bug 34710 and remove this very old unsupported js lib. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #14)
Lets move on with bug 34710 and remove this very old unsupported js lib.
We need to move on with Bug 32333! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #15)
(In reply to Marcel de Rooy from comment #14)
Lets move on with bug 34710 and remove this very old unsupported js lib.
We need to move on with Bug 32333!
Yeah it would be great if a UNIMARC experienced dev could take it up. We can help with testing and QA but not really sure how the functionality is supposed to work yet... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch wraps the release notes| |Greybox include in the OPAC | |with a syspref check on | |IdRef, so that it's only | |loaded when it's needed. CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41665 --- Comment #18 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org