https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147167&action=edit Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field Some libraries would like to have the text version of the serials "published on" field auto-generated from a template. This template should be definable at the subscription level. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create or edit a new subscription 5) Edit the "Publication date template", create a template toolkit template. Keys available are the Koha::Subscription object as 'subscription' and the following serial table columns as keys: serialseq serialseq_x serialseq_y serialseq_z subscriptionid biblionumber status planneddate publisheddate publisheddateext notes routingnotes So your example template could be "[% subscription.subscriptionid %] [% biblionumber %]" 6) Generate the next serial 7) Note the next issue has a "Date published (text)" field based on the template you set! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147167|0 |1 is obsolete| | Attachment #147168|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147173&action=edit Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field Some libraries would like to have the text version of the serials "published on" field auto-generated from a template. This template should be definable at the subscription level. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create or edit a new subscription 5) Edit the "Publication date template", create a template toolkit template. Keys available are the Koha::Subscription object as 'subscription' and the following serial table columns as keys: serialseq serialseq_x serialseq_y serialseq_z subscriptionid biblionumber status planneddate publisheddate publisheddateext notes routingnotes So your example template could be "[% subscription.subscriptionid %] [% biblionumber %]" 6) Generate the next serial 7) Note the next issue has a "Date published (text)" field based on the template you set! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33041 [Bug 33041] Use process_tt in C4::Serial::NewIssue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #3)

Created attachment 147173 [details] [review] Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field

Some libraries would like to have the text version of the serials "published on" field auto-generated from a template. This template should be definable at the subscription level.

Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create or edit a new subscription 5) Edit the "Publication date template", create a template toolkit template. Keys available are the Koha::Subscription object as 'subscription' and the following serial table columns as keys: serialseq serialseq_x serialseq_y serialseq_z subscriptionid biblionumber status planneddate publisheddate publisheddateext notes routingnotes So your example template could be "[% subscription.subscriptionid %] [% biblionumber %]" 6) Generate the next serial 7) Note the next issue has a "Date published (text)" field based on the template you set!

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148470|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148471&action=edit Bug 33039: Update Schema File [DO NOT PUSH] Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148482&action=edit Bug 32924: (follow-up) Add left margin to 'Show mine only' label Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147173|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148534&action=edit Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field Some libraries would like to have the text version of the serials "published on" field auto-generated from a template. This template should be definable at the subscription level. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create or edit a new subscription 5) Edit the "Publication date template", create a template toolkit template. Keys available are the Koha::Subscription object as 'subscription' and the following serial table columns as keys: serialseq serialseq_x serialseq_y serialseq_z subscriptionid biblionumber status planneddate publisheddate publisheddateext notes routingnotes So your example template could be "[% subscription.subscriptionid %] [% biblionumber %]" 6) Generate the next serial 7) Note the next issue has a "Date published (text)" field based on the template you set! Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + if ( index( $template, '[%' ) != -1 ) { # Much faster than regex No problem, but 'much' sounds like exaggerating :) Just in memory.. The variable name could be confusing btw. It is template code. This call worries me: + my $tt = Template->new( + { + EVAL_PERL => 1, + ABSOLUTE => 1, + PLUGIN_BASE => 'Koha::Template::Plugin', + COMPILE_EXT => $use_template_cache ? '.ttc' : '', + COMPILE_DIR => $use_template_cache ? C4::Context->config('template_cache_dir') : '', + FILTERS => {}, + ENCODING => 'UTF-8', + } + ) or die Template->error(); Would prefer to see calling something central like in C4::Templates or in C4::Letters instead. + $schema->txn_begin; + try { + my $text; + $tt->process( Please explain why a process call would need a transaction. Can we just remove it ? Could generating alternative text via a Koha plugin be easier somehow? And without needing a db revision ? Note that we already have: Koha/Plugins/Base.pm: $args->{'template'} = Template->new( { ABSOLUTE => 1, ENCODING => 'UTF-8' } ); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #14)

+ if ( index( $template, '[%' ) != -1 ) { # Much faster than regex No problem, but 'much' sounds like exaggerating :) Just in memory..

https://stackoverflow.com/questions/30744379/unanchored-substring-searching-...

This call worries me: + my $tt = Template->new( + { + EVAL_PERL => 1, + ABSOLUTE => 1, + PLUGIN_BASE => 'Koha::Template::Plugin', + COMPILE_EXT => $use_template_cache ? '.ttc' : '', + COMPILE_DIR => $use_template_cache ? C4::Context->config('template_cache_dir') : '', + FILTERS => {}, + ENCODING => 'UTF-8', + } + ) or die Template->error(); Would prefer to see calling something central like in C4::Templates or in C4::Letters instead.

Bug 33041 already handles that

+ $schema->txn_begin; + try { + my $text; + $tt->process( Please explain why a process call would need a transaction. Can we just remove it ?

Please have a look at C4::Letters. This is now standard procedure for template processing.

Could generating alternative text via a Koha plugin be easier somehow? And without needing a db revision ? Note that we already have: Koha/Plugins/Base.pm: $args->{'template'} = Template->new( { ABSOLUTE => 1, ENCODING => 'UTF-8' } );

That sounds more complicated. If you want to write a POC for that I'd be happy to take a look. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148534|0 |1 is obsolete| | Attachment #148535|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153089&action=edit Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field Some libraries would like to have the text version of the serials "published on" field auto-generated from a template. This template should be definable at the subscription level. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create or edit a new subscription 5) Edit the "Publication date template", create a template toolkit template. Keys available are the Koha::Subscription object as 'subscription' and the following serial table columns as keys: serialseq serialseq_x serialseq_y serialseq_z subscriptionid biblionumber status planneddate publisheddate publisheddateext notes routingnotes So your example template could be "[% subscription.subscriptionid %] [% biblionumber %]" 6) Generate the next serial 7) Note the next issue has a "Date published (text)" field based on the template you set! Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153090|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153139&action=edit Bug 33039: Update Schema File [DO NOT PUSH] Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, no backport for 23.05.x series. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35646 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867 [Bug 35867] Bug 33039 needs to be easier for librarians to use/understand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Attachment #164154|1 |0 is patch| | Attachment #164154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.