[Bug 28915] New: MARC Modification Templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Bug ID: 28915 Summary: MARC Modification Templates should allow specification of a position or range within a control field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When dealing with the MARC Leader, 008, and other fixed length control fields, it would be nice to be able to make the modification templates look at, match on, and alter only a specific position or range. For example, suppose I have several records in which I want to change the 008 position 33 (Literary form) from a 0 to a 1 (nonfiction to fiction). Currently I could tell my modification template to update the 008 of every record I point it at where the character in position 33 is a 0 (using regex to match only that specific character). But then there's no way to change ONLY that character and preserve the rest of the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org --- Comment #1 from AspenCat Team <aspencatteam@clicweb.org> --- This would be useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Noémie Labine <noemie.labine@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine@collecto.ca --- Comment #2 from Noémie Labine <noemie.labine@collecto.ca> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #3 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- This feature would be a huge plus! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Kati Sillgren <kati.sillgren@porvoo.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kati.sillgren@porvoo.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 helm.consortium@nhs.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helm.consortium@nhs.net --- Comment #4 from helm.consortium@nhs.net --- This could be great for dealing with publication dates in the 008. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Heather <flyingendpaper@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #5 from Jason Robb <jrobb@sekls.org> --- Agree, it would be nice to be able to copy a 264$c or 260$c to the proper position of the 008 using MARC modification templates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #6 from Kati Sillgren <kati.sillgren@porvoo.fi> --- This would be very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21860, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34190 Summary|MARC Modification Templates |MARC modification templates |should allow specification |should allow specification |of a position or range |of a position or range |within a control field |within a control field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Jeanne Mauriello <jeanne.mauriello@mainlib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeanne.mauriello@mainlib.or | |g --- Comment #7 from Jeanne Mauriello <jeanne.mauriello@mainlib.org> --- I would also like to be able to do this. For example, we have a list of imported VOX books that are coded as a book in the Leader. We catalog them as audiobooks. Rather than editing each one, since there are lot, I wanted to be able use a marc modification template to edit the records. -- You are receiving this mail because: You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39909 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- In theory, one should be able to use a regex substitution with capturing groups to specify a position within the control field and change just that one character -- I think I filed this original bug before regex groups were working in biblio modification. However, it looks like Bug 39909 is currently preventing that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #8)
In theory, one should be able to use a regex substitution with capturing groups to specify a position within the control field and change just that one character -- I think I filed this original bug before regex groups were working in biblio modification. However, it looks like Bug 39909 is currently preventing that.
I should clarify, I think a user interface that would allow one to just tell Koha a specific position to look at would still be nice to have, even if we get the regex working properly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 40521 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sharon.dugdale@cumbria.gov. | |uk --- Comment #11 from Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> --- I too would find this very useful. I have recently come across over 10,000 of our marc records wrongly catalogued with the 000 field having position 7 set to collection. This makes Koha think that the item is part of a bundle. Every one has to have position 7 changed from "c" to "m" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #12 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198102&action=edit Bug 28915: Add control field support to Koha::SimpleMARC::update_field() Before this patch, control fields were not modifiable using this subroutine. Control fields use character positions instead of subfields. When modifying control fields, this patch makes the subroutine's parameter "subfield" to indicate a character position. An example Koha::SimpleMARC::update_field({ record => $record, field => '008', subfield => '2', values => [09], }); changes field 008 starting from character position 2 to contain values "09". This replaces char pos 2 with "0", and char pos 3 with "9". To test: 1. prove t/SimpleMARC.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #13 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198103&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #14 from Lari Taskula <lari.taskula@hypernova.fi> --- With the above patches, I am using subfield to indicate character position when the given field is a control field. It may not be optimal from the point of naming convention, but with this trick there is no need to add new fields nor additional parameters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198104&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bibliwho@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198102|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198104|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 198116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198116&action=edit Bug 28915: Add control field support to Koha::SimpleMARC::update_field() Before this patch, control fields were not modifiable using this subroutine. Control fields use character positions instead of subfields. When modifying control fields, this patch makes the subroutine's parameter "subfield" to indicate a character position. An example Koha::SimpleMARC::update_field({ record => $record, field => '008', subfield => '2', values => [09], }); changes field 008 starting from character position 2 to contain values "09". This replaces char pos 2 with "0", and char pos 3 with "9". To test: 1. prove t/SimpleMARC.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 198117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198117&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #18 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this and it looks otherwise great but the field after phrase "starting from character position" accepts only one digit numbers. Which means that if you want to change for example the language code from field 008's position 35-37 it is not possible. You'd have to start from position 9 and change everything after it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The database field for that "from subfield" value can only hold a single character. So this needs a change to the template to allow up to two characters and then an atomicupdate to increase the field size in the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198529&action=edit Bug 28915: Add control field support to Koha::SimpleMARC::update_field() Before this patch, control fields were not modifiable using this subroutine. Control fields use character positions instead of subfields. When modifying control fields, this patch makes the subroutine's parameter "subfield" to indicate a character position. An example Koha::SimpleMARC::update_field({ record => $record, field => '008', subfield => '2', values => [09], }); changes field 008 starting from character position 2 to contain values "09". This replaces char pos 2 with "0", and char pos 3 with "9". To test: 1. prove t/SimpleMARC.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198530&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198531&action=edit Bug 28915: (follow-up) Add POD Patch from commit abcbc9b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198532&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Patch from commit c7e8f5a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198533&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Patch from commit 346eb63 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198534&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Patch from commit 4669370 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198539&action=edit Bug 28915: (follow-up) Update kohatructure.sql Patch from commit 6fb4553 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #27 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198540&action=edit Bug 28915: Add control field support to Koha::SimpleMARC::update_field() Before this patch, control fields were not modifiable using this subroutine. Control fields use character positions instead of subfields. When modifying control fields, this patch makes the subroutine's parameter "subfield" to indicate a character position. An example Koha::SimpleMARC::update_field({ record => $record, field => '008', subfield => '2', values => [09], }); changes field 008 starting from character position 2 to contain values "09". This replaces char pos 2 with "0", and char pos 3 with "9". To test: 1. prove t/SimpleMARC.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198541&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #29 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198542&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198543&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198544&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198545&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198546&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #34 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198571&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #35 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198572&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #36 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198573&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #37 from Lari Taskula <lari.taskula@hypernova.fi> --- Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #38 from Lari Taskula <lari.taskula@hypernova.fi> --- Good catch with the 2-digit length issue Anneli and Andrew, and thanks for providing a fix. I wrote a test that caught regression in C4::MarcModificationTemplates, and provided a patch to fix it. I also added a small patch for adjusting maxlength of the subfield whenever subfield (1 char)/charpos (2 chars) is toggled. Because of these new patches I've reset this Bug back to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #39 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198576&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #40 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198577&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #41 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198578&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #42 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198579&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #43 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198580&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #44 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198581&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #45 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198582&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #46 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198583&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198544|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198571|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198572|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #47 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #38)
Good catch with the 2-digit length issue Anneli and Andrew, and thanks for providing a fix. I wrote a test that caught regression in C4::MarcModificationTemplates, and provided a patch to fix it. I also added a small patch for adjusting maxlength of the subfield whenever subfield (1 char)/charpos (2 chars) is toggled. Because of these new patches I've reset this Bug back to "Needs Signoff".
Not a biggie but I think we should choose one of the following two patches, but not both: "Bug 28915: Adjust input maxlength when subfield is used as charpos" "Bug 28915: (follow-up) Increase field size and maxlength in template" Maybe a bit far fetched but a static 2 character maxlength rule increases the potential to misuse the input field when used as a subfield. On the other hand my patch might introduce new bugs with its dynamic attribute modifications. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #48 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198584&action=edit Bug 41343: Further improvements Remove unused patron attribute values sent to the template Send preferred name Use SQL to do date comparison to see if an item is overdue Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #49 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198585&action=edit Bug 28915: Add control field support to Koha::SimpleMARC::update_field() Before this patch, control fields were not modifiable using this subroutine. Control fields use character positions instead of subfields. When modifying control fields, this patch makes the subroutine's parameter "subfield" to indicate a character position. An example Koha::SimpleMARC::update_field({ record => $record, field => '008', subfield => '2', values => [09], }); changes field 008 starting from character position 2 to contain values "09". This replaces char pos 2 with "0", and char pos 3 with "9". To test: 1. prove t/SimpleMARC.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #50 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198586&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #51 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198587&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #52 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198588&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #53 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198589&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #54 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198590&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #55 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198591&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #56 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198592&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #57 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198593&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ephetteplace@cca.edu | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #58 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This is giving me several merge errors. Can I please get a rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198584|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #59 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 198631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198631&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #60 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Andrew Fuerste-Henry from comment #58)
This is giving me several merge errors. Can I please get a rebase?
Done. Please try again :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198585|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198586|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198591|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198592|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #61 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198636&action=edit Bug 28915: Add control field support to Koha::SimpleMARC::update_field() Before this patch, control fields were not modifiable using this subroutine. Control fields use character positions instead of subfields. When modifying control fields, this patch makes the subroutine's parameter "subfield" to indicate a character position. An example Koha::SimpleMARC::update_field({ record => $record, field => '008', subfield => '2', values => [09], }); changes field 008 starting from character position 2 to contain values "09". This replaces char pos 2 with "0", and char pos 3 with "9". To test: 1. prove t/SimpleMARC.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #62 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198637&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #63 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198638&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #64 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198639&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #65 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198640&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #66 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198641&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #67 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198642&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #68 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198643&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #69 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198644&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #70 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198645&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #71 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 200454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200454&action=edit Bug 28915: (RM follow-up): Remove dead code + typo fix Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #72 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement will not be backported to 26.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42950 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 catherine.micklethwaite@nhs.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.micklethwaite@nhs | |.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org