https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #47 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #38)
Good catch with the 2-digit length issue Anneli and Andrew, and thanks for providing a fix. I wrote a test that caught regression in C4::MarcModificationTemplates, and provided a patch to fix it. I also added a small patch for adjusting maxlength of the subfield whenever subfield (1 char)/charpos (2 chars) is toggled. Because of these new patches I've reset this Bug back to "Needs Signoff".
Not a biggie but I think we should choose one of the following two patches, but not both: "Bug 28915: Adjust input maxlength when subfield is used as charpos" "Bug 28915: (follow-up) Increase field size and maxlength in template" Maybe a bit far fetched but a static 2 character maxlength rule increases the potential to misuse the input field when used as a subfield. On the other hand my patch might introduce new bugs with its dynamic attribute modifications. -- You are receiving this mail because: You are watching all bug changes.