[Bug 9718] New: Add POD and comments for Check_Userid and Generate_Userid subs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 Bug ID: 9718 Summary: Add POD and comments for Check_Userid and Generate_Userid subs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 15719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15719&action=edit Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15719|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15751&action=edit Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15751|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16565&action=edit [PASSED QA] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> String patch adding documentation. POD test and other tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9718 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org