[Bug 9764] New: Replace YUI buttons on the authority search popup with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Bug ID: 9764 Summary: Replace YUI buttons on the authority search popup with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/authorities/auth_finder.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The authority search popup has several buttons which are styled with YUI. A couple of these ("Submit," "Cancel") should not be styled at all to conform with general practice. The others ("Clear field," "Create new") can be moved to a toolbar div and styled with Bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15953&action=edit Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the <script> tag in order to eliminate undesirable javascript: pseudo-protocol links. To test, open a bibliographic record for editing and click the authority edit link next to a field with authority-linked data in it. - Confirm that buttons in the popup window look correct. - Confirm that the "Clear field" button clears the field in the MARC editor. - Confirm that the "Create new authority" button launches a blank authority editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15953|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15958&action=edit [SIGNED-OFF] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the <script> tag in order to eliminate undesirable javascript: pseudo-protocol links. To test, open a bibliographic record for editing and click the authority edit link next to a field with authority-linked data in it. - Confirm that buttons in the popup window look correct. - Confirm that the "Clear field" button clears the field in the MARC editor. - Confirm that the "Create new authority" button launches a blank authority editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. All buttons works: look correct, clear works, create works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9779 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15958|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16583&action=edit [PASSED QA] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the <script> tag in order to eliminate undesirable javascript: pseudo-protocol links. To test, open a bibliographic record for editing and click the authority edit link next to a field with authority-linked data in it. - Confirm that buttons in the popup window look correct. - Confirm that the "Clear field" button clears the field in the MARC editor. - Confirm that the "Create new authority" button launches a blank authority editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. All buttons works: look correct, clear works, create works. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done according to test plan. http://bugs.koha-community.org/show_bug.cgi?id=9765 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9764 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org