[Bug 36578] New: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Bug ID: 36578 Summary: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|publisher-location (pl) |Elasticsearch: |index should include field |publisher-location (pl) |752 (for old prints) and |index should include field |also support UNIMARC |752 (for old prints) and | |also support UNIMARC --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 164757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164757&action=edit Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |januszop@gmail.com Depends on| |36269 CC| |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 [Bug 36269] Elasticsearch: publisher-location (pl) index should include 260a/264a (MARC21) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164757|0 |1 is obsolete| | --- Comment #3 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 164780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164780&action=edit Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). Test plan ========= Scenario A (MARC 21, field 752) ------------------------------- 0. Have an installation with Elasticsearch and MARC 21 configuration. 1. Activate subfields 752 $a, $d in the default framework (Visibility: Editor). 2. Edit an existing record with this framework, putting some rare words in the 752 $a and $d subfields. 3. Try to make a search with tis words (general keyword or by publication place, i.e. pl:). 4. You hsold get no results. 5. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 6. Repeat p. 3. You should get your edited record. Scenario B (UNIMARC) -------------------- 0. Have an installation with Elasticsearch and UNIMARC configuration. 1. Try to search for a publication place, either with pl: directly in the search window, or in Advanced search, with Publisher location. With ktd UNIMARC test date you can search for 'Ste Geneviève Cedex'. 2. You should get no results. 3. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 4. Repeat p. 1. You should get some results (with ktd test data set and Ste Geneviève Cedex - record #1). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m QA Contact|januszop@gmail.com | Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164780|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 165146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165146&action=edit Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). Test plan ========= Scenario A (MARC 21, field 752) ------------------------------- 0. Have an installation with Elasticsearch and MARC 21 configuration. 1. Activate subfields 752 $a, $d in the default framework (Visibility: Editor). 2. Edit an existing record with this framework, putting some rare words in the 752 $a and $d subfields. 3. Try to make a search with tis words (general keyword or by publication place, i.e. pl:). 4. You hsold get no results. 5. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 6. Repeat p. 3. You should get your edited record. Scenario B (UNIMARC) -------------------- 0. Have an installation with Elasticsearch and UNIMARC configuration. 1. Try to search for a publication place, either with pl: directly in the search window, or in Advanced search, with Publisher location. With ktd UNIMARC test date you can search for 'Ste Geneviève Cedex'. 2. You should get no results. 3. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 4. Repeat p. 1. You should get some results (with ktd test data set and Ste Geneviève Cedex - record #1). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Grabbing this simple one out of the QA queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This extends the release notes| |Elasticsearch default | |search field mappings to | |include 752 (MARC21) and | |210a, 214a (UNIMARC) in the | |index for place of | |publication. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I don't know if it was changed after by another commit or something, but the fields are now in the "other-control-number" index. other-control-number: label: other-control-number mandatory: ~ mappings: - facet: '' marc_field: '035' marc_type: marc21 sort: 1 suggestible: '' - facet: '' marc_field: 752ad marc_type: marc21 sort: 1 suggestible: '' - facet: '' marc_field: 210a marc_type: unimarc sort: 1 suggestible: '' - facet: '' marc_field: 214a marc_type: unimarc sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' https://git.koha-community.org/Koha-community/Koha/src/branch/main/admin/sea... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37319 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37319 [Bug 37319] Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This could be a merge issue :( Would you mind filing a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #9)
This could be a merge issue :( Would you mind filing a separate bug?
Already done: Bug 37319 - Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/896 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I added them to the manual anyway, even if it will only be true once bug 37319 passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 Bug 36578 depends on bug 36269, which changed state. Bug 36269 Summary: Elasticsearch: publisher-location (pl) index should include 260a/264a (MARC21) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org