[Bug 9009] New: Add separate user js and css of SCO module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Priority: P5 - low Change sponsored?: --- Bug ID: 9009 Assignee: koha-bugs@lists.koha-community.org Summary: Add separate user js and css of SCO module Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Self checkout Product: Koha Right now, the system preferences OPACUserCSS and opacuserjs affect the SCO system. Some libraries would like to add css/js that specifically for the SCO module, but it would negatively impact the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13251&action=edit Bug 9009 - Add separate user js and css of SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13251|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13252&action=edit Bug 9009 - Add separate user js and css of SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13252|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13253&action=edit Bug 9009 - Add separate user js and css of SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13253|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13254&action=edit Bug 9009 - Add separate user js and css of SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add something arbitrary to the new sysprefs SCOUserCSS and SCOUserJS ( such as TestCSS and TestJS ). 4) Load the SCO module in a browser, and view the HTML, verify the CSS and JS values in the system preferences have been included. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add separate user js and |Add separate user js and |css of SCO module |css for SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13254|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13255&action=edit Bug 9009 - Add separate user js and css for SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch Patch complexity|--- |Small patch --- Comment #7 from Marc Véron <veron@veron.ch> --- Small but useful enhancement! However, patch does not apply, sorry: Applying: Bug 9009 - Add separate user js and css for SCO module error: patch failed: installer/data/mysql/sysprefs.sql:386 error: installer/data/mysql/sysprefs.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:6020 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:454 error: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: patch does not apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13255|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13871&action=edit Bug 9009 - Add separate user js and css for SCO module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13871|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 13889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13889&action=edit [SIGNED-OFF] Bug 9009 - Add separate user js and css for SCO module Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Marc Véron <veron@veron.ch> --- Addendum: I tested with an alert('hello') as JavaScript and some background-color for the CSS. Worked as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I think it is a problem that this patch doesn't include a commit message describing what it does, and doesn't include a test plan (even though the test plan is in a comment). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13889|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 13890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13890&action=edit [SIGNED-OFF] Bug 9009 - Add separate user js and css for SCO module Add system preferences SCOUserCSS and SCOUserJS to define separate CSS and JavaScript for the Self Checkout Module. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add something arbitrary to the new sysprefs SCOUserCSS and SCOUserJS ( such as TestCSS and TestJS ). 4) Load the SCO module in a browser, and view the HTML, verify the CSS and JS values in the system preferences have been included. Signed-off-by: Marc Veron <veron@veron.ch> I tested with an alert('hello') as JavaScript and some background-color for the CSS. Worked as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- I always include my test plan in a comment so we don't have them mucking up the git log. I also didn't include a commit message because I thought the title was self explanatory. (In reply to comment #11)
I think it is a problem that this patch doesn't include a commit message describing what it does, and doesn't include a test plan (even though the test plan is in a comment).
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #13)
I always include my test plan in a comment so we don't have them mucking up the git log. I also didn't include a commit message because I thought the title was self explanatory.
If the test plan on the bug is clearly labelled "test plan:" or "to test:" I will probably use it. However, including the test plan in the commit message does increase the chances of the patch getting pushed to Master quickly. Marc's commit message is absolutely perfect, because it tells me in one second exactly what the patch does (adds two sysprefs), how to test it, and what tests Marc performed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> ---
If the test plan on the bug is clearly labelled "test plan:" or "to test:" I will probably use it. However, including the test plan in the commit message does increase the chances of the patch getting pushed to Master quickly. Marc's commit message is absolutely perfect, because it tells me in one second exactly what the patch does (adds two sysprefs), how to test it, and what tests Marc performed.
That's good to know. I'll follow that procedure from now on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: The patch is clean and it works as expected (tested some js and css). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13890|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14288&action=edit Bug 9009 - Add separate user js and css for SCO module Add system preferences SCOUserCSS and SCOUserJS to define separate CSS and JavaScript for the Self Checkout Module. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add something arbitrary to the new sysprefs SCOUserCSS and SCOUserJS ( such as TestCSS and TestJS ). 4) Load the SCO module in a browser, and view the HTML, verify the CSS and JS values in the system preferences have been included. Signed-off-by: Marc Veron <veron@veron.ch> I tested with an alert('hello') as JavaScript and some background-color for the CSS. Worked as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org