[Bug 9315] New: Bad version of String::Random reported by koha_perl_deps.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Bug ID: 9315 Summary: Bad version of String::Random reported by koha_perl_deps.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: bgkriegel@gmail.com One of the patches of bug 7067 introduces a new Koha perl dependency, String::Random. The patch modifies C4/Installer/PerlDependencies.pm, but the configured min_ver=1.4 is non existent. Last version of package is 0.22 (on CPAN) (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11978&action=diff) So koha_perl_deps.pl -u will show as required an incorrect version, Installed Required Module Name Version Version ------------------------------------------------------------------------- String::Random 0.22 * 1.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14253&action=edit Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14253|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14276&action=edit Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works correctly according to the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: The last available version on cpan for the String::Random module is 0.22 So this patch is correct. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14276|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14286&action=edit Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works correctly according to the test plan. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org