[Bug 18949] New: OPAC MARC details holdings table is not styled with < thead>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Bug ID: 18949 Summary: OPAC MARC details holdings table is not styled with <thead> Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org The MARC details holdings table in the OPAC does not have <thead> around the header row, which means it doesn't get styled the same way as the other tables in the OPAC. This is more noticeable when you adding custom styles and themes to OPAC tables, where they don't get applied to this table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 65087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65087&action=edit Bug 18949: Adding thead tags to OPAC MARC details holdings table So that it can be styled alongside other tables in the OPAC. To test: 1) Log into staff side 2) Find OPACUserCSS syspref and add the following CSS: th, .table-bordered>thead>tr:first-child>th { color: red; } 3) Log into the OPAC 4) Go to your fines, your search history, your reading history etc - notice all of these table's headings are styled with red text 5) Go to the detail page of an item, then the MARC view. Notice this table's headings are now styled with red text 6) Apply patch and refresh page 7) Your holdings table should now have red headings. (You can delete the CSS from OPACUserCSS if you'd like.) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65087|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65391&action=edit [SIGNED-OFF] Bug 18949: Adding thead tags to OPAC MARC details holdings table So that it can be styled alongside other tables in the OPAC. To test: 1) Log into staff side 2) Find OPACUserCSS syspref and add the following CSS: th, .table-bordered>thead>tr:first-child>th { color: red; } 3) Log into the OPAC 4) Go to your fines, your search history, your reading history etc - notice all of these table's headings are styled with red text 5) Go to the detail page of an item, then the MARC view. Notice this table's headings are now styled with red text 6) Apply patch and refresh page 7) Your holdings table should now have red headings. (You can delete the CSS from OPACUserCSS if you'd like.) Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65391|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68457&action=edit Bug 18949: Adding thead tags to OPAC MARC details holdings table So that it can be styled alongside other tables in the OPAC. To test: 1) Log into staff side 2) Find OPACUserCSS syspref and add the following CSS: th, .table-bordered>thead>tr:first-child>th { color: red; } 3) Log into the OPAC 4) Go to your fines, your search history, your reading history etc - notice all of these table's headings are styled with red text 5) Go to the detail page of an item, then the MARC view. Notice this table's headings are now styled with red text 6) Apply patch and refresh page 7) Your holdings table should now have red headings. (You can delete the CSS from OPACUserCSS if you'd like.) Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I don't actually see a change following the test plan, but code change makes sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC MARC details holdings |OPAC MARC details holdings |table is not styled with |table is not styled with |<thead> |thead CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org