[Bug 18860] New: OPAC Messaging Settings table is not styled with <thead>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Bug ID: 18860 Summary: OPAC Messaging Settings table is not styled with <thead> Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org The messaging settings table in the OPAC does not have <thead> around the header row, which means it doesn't get styled the same way as the other tables in the OPAC. This is more noticeable when you adding custom styles and themes to OPAC tables, where they don't get applied to this table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64667&action=edit Bug 18860: Adding thead tags to OPAC messaging settings table So that it can be styled alongside other tables in the OPAC. To test: 1) Log into staff side 2) Find OPACUserCSS syspref and add the following CSS: thead { color: red; } 3) Log into the OPAC 4) Go to your fines, your search history, your reading history etc - notice all of these table's headings are styled with red text 5) Go to your messaging. Notice this table's headings are not styled with red text 6) Apply patch and refresh page 7) Your messaging table should now have red headings. (You can delete the CSS from OPACUserCSS if you'd like.) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz Keywords| |Academy Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64667|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 64852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64852&action=edit Bug 18860: Adding thead tags to OPAC messaging settings table So that it can be styled alongside other tables in the OPAC. To test: 1) Log into staff side 2) Find OPACUserCSS syspref and add the following CSS: thead { color: red; } 3) Log into the OPAC 4) Go to your fines, your search history, your reading history etc - notice all of these table's headings are styled with red text 5) Go to your messaging. Notice this table's headings are not styled with red text 6) Apply patch and refresh page 7) Your messaging table should now have red headings. (You can delete the CSS from OPACUserCSS if you'd like.) Sponsored-by: Catalyst IT Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #3 from Jesse Maseto <jesse@bywatersolutions.com> --- This patch does exactly what the tests describe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64852|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66654&action=edit Bug 18860: Adding thead tags to OPAC messaging settings table So that it can be styled alongside other tables in the OPAC. To test: 1) Log into staff side 2) Find OPACUserCSS syspref and add the following CSS: thead { color: red; } 3) Log into the OPAC 4) Go to your fines, your search history, your reading history etc - notice all of these table's headings are styled with red text 5) Go to your messaging. Notice this table's headings are not styled with red text 6) Apply patch and refresh page 7) Your messaging table should now have red headings. (You can delete the CSS from OPACUserCSS if you'd like.) Sponsored-by: Catalyst IT Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|OPAC Messaging Settings |OPAC Messaging Settings |table is not styled with |table is not styled with |<thead> |thead -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org