http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40489&action=edit Bug 14435: Drop table saved_reports - DB Changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Architecture, internals, |Database |and plumbing | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 40489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40489 Bug 14435: Drop table saved_reports - DB Changes Review of attachment 40489: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14435&attachment=40489) ----------------------------------------------------------------- The drop table saved reports atomic update is empty. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40753|0 |1 is obsolete| | --- Comment #8 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40797&action=edit Bug 14435: Drop table saved_reports The table saved_reports is never populated and is not used since 14be4400d84b28369d095b3b0bfa79c3396f44d4 (2009). The 2 subroutines store_results and format_results are never reachable and will also be removed. Note that an empty column "Saved results" were always displayed on the saved report list. Test plan: 0/ Confirm that there is nothing in the saved_reports table and that you have never seen something in it before. 1/ After applying the patch, confirm that you have still acess to the saved report list (reports/guided_reports.pl?phase=Use saved) Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Unit test fails: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. 1/18 DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' at C4/Reports/Guided.pm line 664. DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' at C4/Reports/Guided.pm line 664. # Looks like you planned 18 tests but ran 7. # Looks like your test exited with 255 just after 7. t/db_dependent/Reports_Guided.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 11/18 subtests Test Summary Report ------------------- t/db_dependent/Reports_Guided.t (Wstat: 65280 Tests: 7 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 18 tests but ran 7. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.26 cusr 0.00 csys = 0.28 CPU) Result: FAIL Also, can you delete Koha/Schema/Result/SavedReport.pm? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40930&action=edit Bug 14435: Remove the SavedReport DBIx::Class schema file -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What I am missing here a bit is an idea about what this code was actually used for in the past. According to my research it seems like you used to be able to store the results of a report in that table - which got broken at some point. We have a newer bug report asking for such a feature: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40796|0 |1 is obsolete| | Attachment #40797|0 |1 is obsolete| | Attachment #40929|0 |1 is obsolete| | Attachment #40930|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42196&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10627 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |frederic@tamil.fr --- Comment #16 from Frédéric Demians <frederic@tamil.fr> --- It looks good. Minor merge conflict on master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42196|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44767&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44767|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44795&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes.