[Bug 12224] New: Staff should be able to print Check In slip from Check In UI
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Bug ID: 12224 Summary: Staff should be able to print Check In slip from Check In UI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Staff should be able to print a list of patron's returns from the Check In UI. Some of our patrons want a physical slip when they've returned the books at the counter. The Check-IN UI does not offer any way to print such a slip. Going to the patron's modification log The slip should list all the checked-in items for the patron for today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | Summary|Staff should be able to |Allow easy printing of |print Check In slip from |patron check-in slip |Check In UI | --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- After talking with our staff, it's enough that the slip can be printed from the patron detail page - changed bug description accordingly. Patch to follow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #2 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 28194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28194&action=edit Allow easy printing of patron check-ins for today This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29693&action=edit Bug 12224: Allow easy printing of patron check-ins for today This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like this new feature and it works pretty well already. I have some small things for a follow-up: 1) Entry in the print pull down in circ After checking with a native speaker (I didn't want to suggest something wrong) I think "Print check-in slip" or "Print today's check-in slip" would be better than "Print checked-in today -slip". 2) The new notice template formats the title information quite differently to the "check-out" slip, here for comparison: ISSUESLIP: <checkedout> <p> <<biblio.title>> <br /> Barcode: <<items.barcode>><br /> Date due: <<issues.date_due>><br /> </p> </checkedout> New CHECKINSLIP: <checkedin> <li><<biblio.author>>: <<biblio.title>><br> Barcode: <<items.barcode>><br> </checkedin> Not going to argue about <p> vs. <li>, although I personally prefer the first, but I think the <<biblio.author>>: is problematic. Lots of records don't have a first author in 100 and then the printed information is a bit ugly. If you want t include the author. Maybe just having the title and no : is a bit safer here. But this is not a blocker, just noticing as my example record didn't have an author. 3) Please include the new sample template in the installers for the other languages. Without the template the print will fail and people won't know the code to use for the new notice. Better to have an English template that can be easily modified. 4) Misses unit tests for the new routines... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would be great to see this moving. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #7 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Katrin Fischer from comment #6)
Would be great to see this moving.
It's starting to move. Follow-up coming soon! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pasi.kallinen@pttk.fi |j.kylmala@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29693|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41819&action=edit Rebased to master version of the previous patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #9 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41820&action=edit Bug 12224: (follow-up) Allow easy printing of patron check-ins for today This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print check-in slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. 8) Run unit test t/db_dependent/Members/IssueSlip.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #10 from Joonas Kylmälä <j.kylmala@gmail.com> --- With the follow-up version of the patch the unit test might fail if the test is run at 12 +- 0.0001s AM/PM. What shall we do with this? It would be great to keep those unit tests. Maybe we could change the function GetTodaysReturnsForBorrower to accept a day from which the returns should be retrieved, and also function CheckInSlip to accept a day from which to retrieve the slip. Then in the unit test we could specify the day.. And I think in this way the code would be more generalized. Btw, i'm thinking of integrating the function CheckInSlip with IssueSlip, so another follow-up maybe coming soon! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #10)
With the follow-up version of the patch the unit test might fail if the test is run at 12 +- 0.0001s AM/PM. What shall we do with this? It would be great to keep those unit tests. Maybe we could change the function GetTodaysReturnsForBorrower to accept a day from which the returns should be retrieved, and also function CheckInSlip to accept a day from which to retrieve the slip. Then in the unit test we could specify the day.. And I think in this way the code would be more generalized.
I have fixed the same kind of problem on bug 15029. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Actually it's the same script :) You should provide a patch on top of it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #12)
Actually it's the same script :) You should provide a patch on top of it.
Or just rebase since it's pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41820|0 |1 is obsolete| | --- Comment #14 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 44574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44574&action=edit Bug 12224: Allow easy printing of patron check-ins for today Rebased to master This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44574|0 |1 is obsolete| | --- Comment #15 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 44576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44576&action=edit Bug 12224: Allow easy printing of patron check-ins for today Last rebase wasn't good, now let's try again. Rebased to master This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41820|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41819|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41819|0 |1 is obsolete| | --- Comment #16 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 44582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44582&action=edit Bug 12224: Allow easy printing of patron check-ins for today Let's try rebasing for the third time ! :) This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41820|0 |1 is obsolete| | --- Comment #17 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 44584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44584&action=edit Bug 12224: (follow-up) Allow easy printing of patron check-ins for today Rebased version This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print check-in slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. 8) Run unit test t/db_dependent/Members/IssueSlip.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Joonas Kylmälä <j.kylmala@gmail.com> --- These patches should be now ready to push to master. But maybe one more sign-off would be in place! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |frederic@tamil.fr --- Comment #19 from Frédéric Demians <frederic@tamil.fr> --- You add the new CHECKINSLIP to : installer/data/mysql/en/mandatory/sample_notices.sql As suggested by Katrin in comment 5, you should add this also in other languages samples notices: a cut-and-paste of the English version is enough. t/db_dependent/Members/IssueSlip.t raises warning about masking variables earlier declaration, and the test fails (for me). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org