[Bug 37972] New: Allow selection of tab in patron's summary table by query param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Bug ID: 37972 Summary: Allow selection of tab in patron's summary table by query param Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org I think it would be very useful to be able to immediately pick a tab from the user summary table via a query param, especially for actions within the different tabs because we can then reroute to the specific tab in the controller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171831&action=edit Bug 37972: Allow selection of tab in patron's summary table by query param To test: 1) Apply the patch 2) Place a hold on any biblio with the 'koha' patron for example 3) Authenticate in the OPAC with the patron you picked in step 1 4) Open opac-user.pl with the query param 'tab': /cgi-bin/koha/opac-user.pl?tab=opac-user-holds 5) Note that the holds tab in the patron's user summary is automatically selected 6) Sign-off I'm totally open to renaming the query param, so if you have a suggestion that's more consistent with the rest of koha, I'm all ears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33738 [Bug 33738] Add bookings to the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- Get this error when attempting to access patron's account (maybe a common is required for the code change: tab = > $query->param('tab'); ): Could not compile /kohadevbox/koha/opac/opac-user.pl: syntax error at /kohadevbox/koha/opac/opac-user.pl line 409, near ");" syntax error at /kohadevbox/koha/opac/opac-user.pl line 416, near ")" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/opac/opac-user.pl line 453. at /usr/share/perl5/CGI/Compile.pm line 144 in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144 141: my $code = $self->_eval($eval); 142: my $exception = $@; 143: 144: die "Could not compile $script: $exception" if $exception; 145: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Ah, thanks David. It's the old ';' instead of ','. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171874&action=edit Bug 37972: (follow-up) Correct syntax error in opac/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171831|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 171885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171885&action=edit Bug 37972: Allow selection of tab in patron's summary table by query param To test: 1) Apply the patch 2) Place a hold on any biblio with the 'koha' patron for example 3) Authenticate in the OPAC with the patron you picked in step 1 4) Open opac-user.pl with the query param 'tab': /cgi-bin/koha/opac-user.pl?tab=opac-user-holds 5) Note that the holds tab in the patron's user summary is automatically selected 6) Sign-off I'm totally open to renaming the query param, so if you have a suggestion that's more consistent with the rest of koha, I'm all ears. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171874|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 171886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171886&action=edit Bug 37972: (follow-up) Correct syntax error in opac/opac-user.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 --- Comment #7 from David Nind <david@davidnind.com> --- Thanks for fixing! I think I would prefer opac-patron-xxx, however opac-user-xxx exists already so we probably shouldn't change it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171885|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171900&action=edit Bug 37972: Allow selection of tab in patron's summary table by query param To test: 1) Apply the patch 2) Place a hold on any biblio with the 'koha' patron for example 3) Authenticate in the OPAC with the patron you picked in step 1 4) Open opac-user.pl with the query param 'tab': /cgi-bin/koha/opac-user.pl?tab=opac-user-holds 5) Note that the holds tab in the patron's user summary is automatically selected 6) Sign-off I'm totally open to renaming the query param, so if you have a suggestion that's more consistent with the rest of koha, I'm all ears. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171886|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171901&action=edit Bug 37972: (follow-up) Correct syntax error in opac/opac-user.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171902&action=edit Bug 37972: (QA follow-up) add missing filter Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Keywords| |release-notes-needed --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not going to block this, but I feel we have solved this in other spots already. Adding Owen for some additional insight. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds the release notes| |ability to direct links to | |specific tabs of the OPAC | |patron summary with the | |following syntax: | | | |/cgi-bin/koha/opac-user.pl? | |tab=opac-user-holds CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39003 [Bug 39003] Cannot see suspend column in user's hold table on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 [Bug 41558] Broken links to tab on opac-user -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org