[Bug 32104] New: console error on additional_content.pl after saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Bug ID: 32104 Summary: console error on additional_content.pl after saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). 2. Save the content ( not Save and continue ) 3. Notice the console error: Uncaught TypeError: firstTab[0] is undefined This only seems to happen for me when using CodeMirror. Using the WYSIWYG editor does not produce the console error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 143154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143154&action=edit Bug 32104: Prevent console error on additonal-contents.pl To test: 1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). 2. Save the content ( not Save and continue ) 3. Notice the console error: 4. Apply patch 5. Try 1 & 2 again. 6. No error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143154|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143164&action=edit Bug 32104: Prevent console error on additonal-contents.pl To test: 1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). 2. Save the content ( not Save and continue ) 3. Notice the console error: 4. Apply patch 5. Try 1 & 2 again. 6. No error. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't see the console error on master - could you please verify if maybe bug 31609 fixed this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3)
I didn't see the console error on master - could you please verify if maybe bug 31609 fixed this?
It did not, the console error remains. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I couldn't make it happen when I tried earlier, maybe another set of eyes would help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- It looks like I can only make the error happen when using Firefox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #6)
It looks like I can only make the error happen when using Firefox.
Hm I did use Firefox :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Same for me, I don't get the error (using Firefox). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
Same for me, I don't get the error (using Firefox).
Interesting! Not quite sure what is going on here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143164|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144021&action=edit Bug 32104: Prevent console error on additonal-contents.pl To test: 1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). 2. Save the content ( not Save and continue ) 3. Notice the console error: 4. Apply patch 5. Try 1 & 2 again. 6. No error. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|console error on |Console error on |additional_content.pl after |additional_content.pl after |saving |saving -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|console error on |Console error on |additional_content.pl after |additional_content.pl after |saving |saving Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #11)
Pushed to master for 22.11.
Did you get the warning? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org