[Bug 32175] New: Flatpickr usage causes acquisitions item info clone to fail when dateaccessioned is filled in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 Bug ID: 32175 Summary: Flatpickr usage causes acquisitions item info clone to fail when dateaccessioned is filled in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Bug 29369 added Flatpickr to the "Date acquired" field When creating items at receival time in Acquisitions, the item info should be cloned/prefilled for the next item after adding an item. However, if you've added a value to "Date acquired", it will trigger a Javascript error that stops the clone/prefill from working. This is because the "input[name='field_value']" element is wrapped by '<span class="flatpickr_wrapper">' which creates a problematic inconsistency with the HTML structure... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29369 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369 [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (Looks like PrefillItem is also broken for regular cataloguing in 21.11 at least.. fun) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I don't know how widely used this cloneItemBlock function is... although it looks like it might not be working correctly in other parts of Koha. I'm tempted to just handle the error, although that means "Date acquired" won't be cloned... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Flatpickr usage causes |Item info not cloning when |acquisitions item info |receiving multiple items |clone to fail when |due to Flatpickr issue |dateaccessioned is filled | |in | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 143738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143738&action=edit Bug 32175: Prevent Javascript error by checking for kohafield sibling This patch checks for kohafield sibling before proceeding with data clone when creating items during receival. If the kohafield sibling is not available, don't try to clone the value. Test plan: 1. Create a test vendor 2. Create a test basket (create item on receival) 3. Create a test order for 3 items 4. Close the test basket 5. Receive the order 6. Fill out many item fields including "Date acquired" 7. Click "Add item" 8. Note that the fields aren't cloned and there is a Javascript error in the console 9. Apply the patch 10. Refresh the page 11. Fill out many item fields including "Date acquired" 12. Click "Add item" 13. Note that the fields are cloned, except "Date acquired" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Note that not cloning "Date acquired" isn't too big of a deal, as it will automatically be set (these days) when saving the item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I had a go at testing a couple of times, but I couldn't replicate the issue (on current master just updated, using Firefox). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #5)
I had a go at testing a couple of times, but I couldn't replicate the issue (on current master just updated, using Firefox).
Hmm, ok, I'll have another look at this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Same, I cannot recreate on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This sounds a bit similar to bug 23202 we encountered after the switch to flatpickr for 'items on ordering'. I also had no issues testing this on current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Closing, please reopen if needed. *** This bug has been marked as a duplicate of bug 23202 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org