[Bug 6984] New: Holds Statistics Doesn't Work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Bug #: 6984 Summary: Holds Statistics Doesn't Work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Reports AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org The subject says it all. I tested this on 3.4 and on master (and on multiple libraries) and it just never gives you results no matter what combo you try. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 14:47:12 UTC --- Still valid in 3.6 There is an SQL error in the logs : [Wed Oct 26 16:46:07 2011] reserves_stats.pl: DBD::mysql::st execute failed: Unknown column 'holdingbranch' in 'where clause' at /home/paul/koha.dev/koha-community/reports/reserves_stats.pl line 274. [Wed Oct 26 16:46:07 2011] reserves_stats.pl: DBD::mysql::st fetchall_hashref failed: statement contains no result [err was 4 now 2000000000] [Wed Oct 26 16:46:07 2011] reserves_stats.pl: Field 'line' does not exist (not one of ) at /home/paul/koha.dev/koha-community/reports/reserves_stats.pl line 276. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |gcollum@gmail.com --- Comment #2 from Garry Collum <gcollum@gmail.com> 2012-02-01 15:39:14 UTC --- Created attachment 7412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7412 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7412|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2012-02-02 05:35:27 UTC --- Created attachment 7420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7420 Bug 6984 - Holds statistics doesn't work. This patch fixes several errors in reserves_stats.pl and reserves_stats.tt. Testing - To test this patch, data must be in either the reserves table or old_reserves or both. The following SQL will give you the raw data that is used by the report. SELECT priority, found, reservedate, notificationdate, reminderdate, waitingdate, cancellationdate, borrowers.categorycode, items.itype, reserves.branchcode, holdingbranch, items.homebranch, items.ccode, items.location, items.itemcallnumber, borrowers.sort1, borrowers.sort2 FROM reserves LEFT JOIN borrowers on (borrowers.borrowernumber = reserves.borrowernumber) LEFT JOIN items on (items.itemnumber = reserves.itemnumber) UNION SELECT priority, found, reservedate, notificationdate, reminderdate, waitingdate, cancellationdate, borrowers.categorycode, items.itype, old_reserves.branchcode, holdingbranch, items.homebranch, items.ccode, items.location, items.itemcallnumber, borrowers.sort1, borrowers.sort2 FROM old_reserves LEFT JOIN borrowers on (borrowers.borrowernumber = old_reserves.borrowernumber) LEFT JOIN items on (items.itemnumber = old_reserves.itemnumber) To test the notificationdate and reminderdate, I added data to the old_reserves table, since I have never run notices on my test machine. Ex: UPDATE old_reserves SET notificationdate = "2012-01-29", reminderdate = "2012-01-29" WHERE timestamp = "2012-01-29 20:09:34"; Signed-off-by: Liz Rea <wizzyrea@gmail.com> Confirm original bug -- Reports work as expected now! prove t xt t/db_dependent no different from master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |wizzyrea@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> 2012-02-03 12:41:34 UTC --- Mostly cleans up T:T scope and spacing/layout in Perl. Adds an additional elsif for exclusive less than, and changes how a few variables are referenced (hash v. hashref). All in all, this improves coding style, and doesn't touch any core C4 modules, so tests should all be safe and the same. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6984 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org