[Bug 7461] New: cart offering to remove items when closing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Bug #: 7461 Summary: cart offering to remove items when closing Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha.sekjal@gmail.com If you have items selected in your cart and you choose to hide the window it asks if you're sure you want to remove items from cart - even though I didn't click the option to remove things from my cart. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2012-01-24 14:16:07 UTC --- Created attachment 7314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7314 Proposed fix The "hide window" button in the cart called a quit() function which deletes any checked items. My understanding of the "hide window" button is that it should *only* hide the window, not perform any other operations. I'm removing the calls to the quit() function in both the OPAC and staff client and adding a CSS class, "close," which is already tied via jQuery to the window.close() function. To test in both OPAC and staff client: Add items to the cart. Try clicking the "hide window" button with items selected and without. In both cases the window should close without affecting the contents of the cart. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7314|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2012-01-24 14:29:29 UTC --- Created attachment 7316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7316 [SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing The "hide window" button in the cart called a quit() function which deletes any checked items. My understanding of the "hide window" button is that it should *only* hide the window, not perform any other operations. I'm removing the calls to the quit() function in both the OPAC and staff client and adding a CSS class, "close," which is already tied via jQuery to the window.close() function. To test in both OPAC and staff client: Add items to the cart. Try clicking the "hide window" button with items selected and without. In both cases the window should close without affecting the contents of the cart. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 12:26:39 UTC --- QA Comment: Works as advertised. Agree that it is unexpected that Hide asks for confirmation for deleting selected items from cart. Well documented small change. Tiny side-note: it seems that the function quit in the javascript now is obsolete. Could it be removed (follow-up)? Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7461 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org