[Bug 8180] New: cataloguing/additem.pl plack scoping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Priority: P5 - low Change sponsored?: --- Bug ID: 8180 Assignee: gmcharlt@gmail.com Summary: cataloguing/additem.pl plack scoping Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin@rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9884&action=edit Bug 8180 - cataloguing/additem.pl plack scoping $dbh needs our scoping when using "Add item" to prevent error Can't call method "prepare" on an undefined value at /srv/koha/cataloguing/additem.pl line 88. Test scenario: 1. start intranet with plack 2. select one Edit items on one record 3. fill in new item and click on "Add item" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks| |7172 Assignee|gmcharlt@gmail.com |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This works fine for me under Plack. Can you please confirm exactly how one would go about reproducing this bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I just verified it with current master using following: 1. search for word in intranet (I'm using human with URL /cgi-bin/koha/catalogue/search.pl?idx=kw&q=human&idx=kw&q=&idx=kw&q=&limit=&limit=&limit=&limit=&limit=&sort_by=relevance) 2. select "edit item" from first result 3. press "add item" button on add item form 4. Can't call method "prepare" on an undefined value at /srv/koha/cataloguing/additem.pl line 88. Hope this helps. p.s. I can also reproduce it with different search queries, and this patch still fixes problem for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- I also can not replicate this issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This bug depends on barcodes, so your item.barcode must be used in framework and you should have (any) barcode plugin enabled in system preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Dobrica, my item.barcode is linked to Plugin:barcode.pl. Also, i use autoBarcode syspref but can't reproduce the bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9884|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10270&action=edit [SIGNED-OFF] Bug 8180 - cataloguing/additem.pl plack scoping Steps to reproduce the bug: - Set autoBarcode syspref to "incremental" ("generated in the form 1, 2, 3.") - Assure you have an item subfield mapped to items.barcode - Go to cataloguing/additem.pl and add a new item leaving empty the barcode field. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- I can't reproduce with: - syspref autoBarcode=incremental (generated in the form 1, 2, 3.) - items.barcode mapped with 995$f mysql> select kohafield, frameworkcode from marc_subfield_structure where tagfield=995 and tagsubfield='f'; +---------------+---------------+ | kohafield | frameworkcode | +---------------+---------------+ | items.barcode | | | items.barcode | ACQ | - I can edit and create items on a biblio which already contains (or not) items So I can't passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #9 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I probably forgot to say that you SHOULD NOT enter barcode using plugin, but to leave it empty to trigger code path which this bug fixes. If you already have barcode or you fill it in using plugin it will not show up. Jonathan, could you please insert warn inside sub _increment_barcode to verify which framework gets passed like this: my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode",$frameworkcode); warn "## $frameworkcode $tagfield $tagsubfield"; unless ($record->field($tagfield)->subfield($tagsubfield)) { # triggers bug } In my case this warn produce "LIB 952 p" which is consistent with our configuration: mysql> select variable,value from systempreferences where variable = 'autoBarcode' ; +-------------+-------------+ | variable | value | +-------------+-------------+ | autoBarcode | incremental | +-------------+-------------+ mysql> select kohafield, frameworkcode, tagfield, tagsubfield from marc_subfield_structure where kohafield='items.barcode' and frameworkcode='LIB' ; +---------------+---------------+----------+-------------+ | kohafield | frameworkcode | tagfield | tagsubfield | +---------------+---------------+----------+-------------+ | items.barcode | LIB | 952 | p | +---------------+---------------+----------+-------------+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Plack scoping change only, ruled safe for CGI environments, marking Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org