http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9892&action=edit Bug 8183 - acqui/parcels.pl plack scoping Scope our $template for plack to prevent following error: Can't call method "param" on an undefined value at /srv/koha_ffzg/acqui/parcels.pl line 177. Test scenario: 1. Home > Acquisitions > Search for vendor 2. click on "Receive shipment" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm, I can't recreate this bug I'm afraid -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This bug seems to be specific to bookseller=2 on our system and doesn't appear for others, so I will have to investigate a bit more why is that so. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9892|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10269&action=edit [SIGNED-OFF] Bug 8183 - acqui/parcels.pl plack scoping It fixes the bug, so I signoff. But it also works by passing the $template variable to the sub, which seems cleaner to me than using global variables in subs. Why did you choose this solution ? (I'm just curious :-)) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I tried to always make smallest possible change to code when introducing plack scoping. Since other patches for plack use global scoping, I opted to do it consistently instead of changing method signature. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.