https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177692|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 177695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177695&action=edit Bug 39076: Use state variable to avoid creating extra ES connections As elsewhere in the code, we should use a state variable for our 'bib_searcher' object to avoid overhead of extra ES connections. Worth noting - we don't actually use the 'bib_searcher' at all during record auto linking as we pass skipmetadata To test: 0 - Apply patch 1 - Enable biblio auto linking AutoLinkBiblios, CatalogModuleRelink, LinkerRelink 2 - Stage and import a marc file 3 - Confirm record authorities link as expected 4 - Search authorities in the staff interface 5 - Confirm usage counts are shown for results Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- So I was tempted to say this isn't really a Koha-ish way of doing things... but it turns out that it is! It's already done heaps in C4/Heading.pm and C4/Matcher.pm Normally, I think that we'd just store the Koha::SearchEngine::Elasticsearch::Search object in $self (as an attribute of Koha::SearchEngine::Search that is), but that would take more code. It might be easier to understand for someone unfamiliar with "state", but it's less elegant for sure. While "state" seems like it could be abused in some scenarios, I think that this one is a pretty reasonable place to use it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177695|0 |1 is obsolete| | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 177714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177714&action=edit Bug 39076: Use state variable to avoid creating extra ES connections As elsewhere in the code, we should use a state variable for our 'bib_searcher' object to avoid overhead of extra ES connections. Worth noting - we don't actually use the 'bib_searcher' at all during record auto linking as we pass skipmetadata To test: 0 - Apply patch 1 - Enable biblio auto linking AutoLinkBiblios, CatalogModuleRelink, LinkerRelink 2 - Stage and import a marc file 3 - Confirm record authorities link as expected 4 - Search authorities in the staff interface 5 - Confirm usage counts are shown for results Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- On a side note, does this fix your prod issue, Nick? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.