[Bug 37755] New: Change in Bootstrap5 has broken batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Bug ID: 37755 Summary: Change in Bootstrap5 has broken batch patron modification Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Hi all, We've identified a bug introduced since the move to Bootstrap5 which caused the modborrowers.pl to break. It looks like the problem has happened because a class has been changed in the markup. I will submit a one-liner shortly to fix this issue. Jake. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@ptfs-europe.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #1 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 170802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170802&action=edit Bug 37755: Fixed JavaScript for modification tabs This patch addresses a new bug which prevents correct submission on mod borrowers and mod records (mod + delete). The bug appears to have been introduced since the recent Bootstrap5 switch, and shouldn't be surfacing anywhere else in the system Note that the test plan focuses on tools/modborrowers.pl. The error also appears to exist on tools/batch_record_modification.pl and tools/batch_delete_records.pl, but is a lot harder to reproduce. Please see https://chat.koha-community.org/koha-community/pl/fmnzzgy5cpghtpdc9a9ow75scr and follow-up comments for details on reproducing this. To test: a) go to tools/modborrowers.pl and try to enter valid cardnumbers or borrowernumbers 1) notice how you cannot proceed b) APPLY PATCH c) repeat steps a 1) notice how you can now proceed d) SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 CC| |paul.derscheid@lmscloud.de --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Bug 35402 has already been pushed but let's keep track of follow-ups this way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #3 from Jake Deery <jake.deery@ptfs-europe.com> --- re: testing tools/batch_record_modification.pl and tools/batch_delete_records.pl These appear to work on the surface, but I don't think they are correct. If you run this on tools/batch_record_modification.pl (when you're on the entry page, via the browser console): $("#record_ids_selection").each(function() { var tab = $(this).find('#batch_mod_form li.active:first a').attr('href'); console.log(tab); }); You get 'undefined'. I don't think that's good, obviously. :-) If you try again with the new JavaScript: $("#record_ids_selection").each(function() { var tab = $(this).find('#batch_mod_form li a.active:first').attr('href'); console.log(tab); }); You should get the HREF of the active tab. Much more expected! * * * The same can be applied to tools/batch_delete_records.pl... $("#record_ids_selection").each(function() { var tab = $(this).find('#batch_del_form:active:first a').attr('href'); console.log(tab); }); We actually hit an error. Meanwhile... $("#record_ids_selection").each(function() { var tab = $(this).find('#batch_del_form li a.active:first').attr('href'); console.log(tab); }); Should give us that HREF again. Happy times! * * * Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35402 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170802|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170803&action=edit Bug 37755: Fixed JavaScript for modification tabs This patch addresses a new bug which prevents correct submission on mod borrowers and mod records (mod + delete). The bug appears to have been introduced since the recent Bootstrap5 switch, and shouldn't be surfacing anywhere else in the system Note that the test plan focuses on tools/modborrowers.pl. The error also appears to exist on tools/batch_record_modification.pl and tools/batch_delete_records.pl, but is a lot harder to reproduce. Please see https://chat.koha-community.org/koha-community/pl/fmnzzgy5cpghtpdc9a9ow75scr and follow-up comments for details on reproducing this. To test: a) go to tools/modborrowers.pl and try to enter valid cardnumbers or borrowernumbers 1) notice how you cannot proceed b) APPLY PATCH c) repeat steps a 1) notice how you can now proceed d) SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170803|0 |1 is obsolete| | --- Comment #5 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 170806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170806&action=edit Bug 37755: Fixed JavaScript for modification tabs This patch addresses a new bug which prevents correct submission on mod borrowers and mod records (mod + delete). The bug appears to have been introduced since the recent Bootstrap5 switch, and shouldn't be surfacing anywhere else in the system Note that the test plan focuses on tools/modborrowers.pl. The error also appears to exist on tools/batch_record_modification.pl and tools/batch_delete_records.pl, but is a lot harder to reproduce. Please see https://chat.koha-community.org/koha-community/pl/fmnzzgy5cpghtpdc9a9ow75scr and follow-up comments for details on reproducing this. To test: a) go to tools/modborrowers.pl and try to enter valid cardnumbers or borrowernumbers 1) notice how you cannot proceed b) APPLY PATCH c) repeat steps a 1) notice how you can now proceed d) SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Found something: Go to /tools/modborrowers.pl Tab "By card number", enter cardnumber '23529000224510' Tab "By borrowernumber", enter 1 Continue => Both patrons are picked, I think we expect only the one from the tab we were before pressing "Continue" (which is the point of this code) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- Hi Jonathan, Sorry, but I'm now able to reproduce your behaviour. Can I ask if you cleared your browser cache, or ran restart_all? Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Oops sorry, it seems to work correctly for the batch patron mod. However it seems broken on "Batch record deletion" => "Upload a file" is cleared when you "Continue", even if you are on this tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170806|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170813&action=edit Bug 37755: Fixed JavaScript for modification tabs This patch addresses a new bug which prevents correct submission on mod borrowers and mod records (mod + delete). The bug appears to have been introduced since the recent Bootstrap5 switch, and shouldn't be surfacing anywhere else in the system Note that the test plan focuses on tools/modborrowers.pl. The error also appears to exist on tools/batch_record_modification.pl and tools/batch_delete_records.pl, but is a lot harder to reproduce. Please see https://chat.koha-community.org/koha-community/pl/fmnzzgy5cpghtpdc9a9ow75scr and follow-up comments for details on reproducing this. To test: a) go to tools/modborrowers.pl and try to enter valid cardnumbers or borrowernumbers 1) notice how you cannot proceed b) APPLY PATCH c) repeat steps a 1) notice how you can now proceed d) SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170814&action=edit Bug 37755: Fix batch del record (adding the missing _panel suffix) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #8)
However it seems broken on "Batch record deletion" => "Upload a file" is cleared when you "Continue", even if you are on this tab.
Fixed in the last patch. I think we are good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #12 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks, Jonathan. I was looking in tools/modborrowers.pl for the problem – duh! Good to get this one moved quickly, it could have been a show-stopper! Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 [Bug 37360] Add 'Protected Status' as one of the things that can be updated via Batch Patron Modification tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 Bug 37755 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org